Add support for java.version file - #23
Draft
e-korolevskii wants to merge 51 commits into
Draft
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
marko-zivic-93
approved these changes
Nov 25, 2022
panticmilos
approved these changes
Nov 25, 2022
IvanZosimov
reviewed
Nov 28, 2022
Comment thread
src/setup-java.ts
Outdated
Comment thread
src/setup-java.ts
Outdated
Comment thread
src/setup-java.ts
Outdated
Comment thread
src/setup-java.ts
Outdated
Comment thread
src/setup-java.ts
Outdated
MaksimZhukov
approved these changes
Dec 8, 2022
* Fix typo in README.md (actions#419) `diractory` -> `directory` * Revert "Add support for Oracle JDK (actions#401)" (actions#421) This reverts commit 6cdf39a. Co-authored-by: Brian Cristante <33549821+brcrista@users.noreply.github.com> * adding check for prerelease * add debug lines * add minor fix * expand e2e tests with corretto Co-authored-by: Ashley <73482956+ascopes@users.noreply.github.com> Co-authored-by: Brian Cristante <33549821+brcrista@users.noreply.github.com>
Co-authored-by: Marko Zivic <100996310+marko-zivic-93@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
In the scope of this issue, we need to add a feature to set java-version from the file.
Related issue:
https://github.com/actions/runner-images-internal/issues/4599
Check list: