Repository navigation
Speed up CI - #261
Merged
tjschuck merged 4 commits intoMay 16, 2022
Merged
Speed up CI#261tjschuck merged 4 commits into
tjschuck merged 4 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
nwjsmith
force-pushed
the
ci-improvements
branch
4 times, most recently
from
3fe154d to
c045eeb
Compare
May 16, 2022 18:09
tjschuck
reviewed
May 16, 2022
tjschuck
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
Can you also please remove the Appveyor badge from the README?
Sorry, something went wrong.
Comment thread
.github/workflows/ruby.yml
| - 2.3 | ||
| - 2.4 | ||
| - 2.5 | ||
| - 2.6 |
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
Can you please revert this bit? As long as it's not insurmountable, we try to maintain working compatibility for as far back as possible. It would be nice to know if/when it broke on older versions so we can fix it if possible instead of dropping support.
Sorry, something went wrong.
Closed
Merged
Copy link
Copy Markdown
Contributor
Author
|
@tjschuck dropped the removal of 2.x and removed the badge, thank you! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes EOL-ed versions of Ruby from the test matrix, and the old
Appveyor configuration now that Windows CI is running via GitHub
Actions.
It works around a JDK issue for JRuby tests, getting those back to green. I also took the opportunity to fix a couple of compiler warnings.