CI: run windows_smoke verification only on the native MINGW64 lane · etr/libhttpserver@27d2833 · GitHub

etr / libhttpserver Public

• Notifications You must be signed in to change notification settings
• Fork 190
• Star 953

• Code
• Issues 7
• Pull requests 2
• Actions
• Projects
• Wiki
• Security and quality
• Insights

Additional navigation options

Commit 27d2833

Browse filesBrowse the repository at this point in the historyBrowse files

etr

and

claude

committed

CI: run windows_smoke verification only on the native MINGW64 lane

The 'Verify Windows smoke test ran' step greps ws_start_stop.log for the windows_smoke test, but ran on BOTH Windows subsystems. windows_smoke is gated on _WINDOWS (defined(_WIN32) && !defined(__CYGWIN__)) and does native-Windows setup (winsock2, _WIN32_WINNT), so it is correctly NOT compiled on the MSYS (Cygwin/POSIX) lane where _WIN32 is undefined — making the check fail there ('windows_smoke did not appear'). Restrict the step to matrix.msys-env == 'MINGW64' (the native lane where it is built and run), matching the existing MINGW64/MSYS conditionals elsewhere in the workflow. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NpysYDDJac63yz2mZKKiDf

1 parent 81742ac commit 27d2833
Copy full SHA for 27d2833

1 file changed

+10-7Lines changed: 10 additions & 7 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• .github/workflows
  • verify-build.yml

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎.github/workflows/verify-build.yml‎

Copy file name to clipboardExpand all lines: .github/workflows/verify-build.yml

+10-7Lines changed: 10 additions & 7 deletions

Original file line number	Diff line number	Diff line change
@@ -1371,12 +1371,15 @@ jobs:
1371	1371	if: ${{ failure() && matrix.build-type != 'iwyu' && matrix.compiler-family != 'arm-cross' && matrix.build-type != 'header-hygiene' }}
1372	1372
1373	1373	- name: Verify Windows smoke test ran (TASK-077)
1374		- # TASK-077: assert the new `ws_start_stop_suite::windows_smoke` test
1375		- # is actually being compiled and executed on the MinGW64 / MSYS lanes
1376		- # so that the basic daemon-start-accept-one-GET path is observed end
1377		- # to end on Windows. Without this, a future build-flag tweak that
1378		- # inadvertently turns off the `#ifdef _WINDOWS` branch would silently
1379		- # erase the Windows round-trip coverage.
	1374	+ # TASK-077: assert the `ws_start_stop_suite::windows_smoke` test is
	1375	+ # actually compiled and executed on the native MinGW64 lane so the basic
	1376	+ # daemon-start-accept-one-GET path is observed end to end on Windows.
	1377	+ # Without this, a future build-flag tweak that inadvertently turns off the
	1378	+ # `#ifdef _WINDOWS` branch would silently erase the Windows round-trip
	1379	+ # coverage. Restricted to MINGW64: windows_smoke is gated on _WINDOWS
	1380	+ # (defined(_WIN32) && !defined(__CYGWIN__)) and does native-Windows setup
	1381	+ # (winsock2 / _WIN32_WINNT), so it is deliberately NOT built on the MSYS
	1382	+ # (Cygwin/POSIX) lane where _WIN32 is undefined.
1380	1383	shell: bash
1381	1384	run: |
1382	1385	cd build
@@ -1388,7 +1391,7 @@ jobs:
1388	1391	echo "ERROR: windows_smoke test did not appear in test/ws_start_stop.log" >&2
1389	1392	exit 1
1390	1393	fi
1391		- if: ${{ matrix.os-type == 'windows' }}
	1394	+ if: ${{ matrix.os-type == 'windows' && matrix.msys-env == 'MINGW64' }}
1392	1395
1393	1396	- name: Run Valgrind checks
1394	1397	timeout-minutes: 90

0 commit comments

Comments

0 (0)