Commit fe1e562
committed
CI: fix python version
Turns out this is important for the black formatting tool to work
correctly. The formatting won't generally change between python versions
(it only depends on `black`'s version), but the formatted code needs to
be parseable by the system python version. One script uses
```python
def foo[T](x: T) -> T:
```
syntax, which is only supported in Python 3.12 and later.
Running `pre-commit` will now require a python 3.12 installation (which
is already what we mandate for internal developer environment setup).
The error in case of absence of such a version is pretty clear though.1 parent 70647ce commit fe1e562
3 files changed
Lines changed: 7 additions & 4 deletions
File tree
- .github/workflows
- misc/scripts/models-as-data
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -22,6 +22,9 @@ jobs: | |||
| 22 | 22 | runs-on: ubuntu-latest | |
| 23 | 23 | steps: | |
| 24 | 24 | - uses: actions/checkout@v4 | |
| 25 | + - uses: actions/setup-python@v5 | ||
| 26 | + with: | ||
| 27 | + python-version: '3.12' | ||
| 25 | 28 | - uses: pre-commit/action@646c83fcd040023954eafda54b4db0192ce70507 | |
| 26 | 29 | name: Check that python code is properly formatted | |
| 27 | 30 | with: | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1,5 +1,7 @@ | |||
| 1 | 1 | # See https://pre-commit.com for more information | |
| 2 | 2 | # See https://pre-commit.com/hooks.html for more hooks | |
| 3 | + default_language_version: | ||
| 4 | + python: python3.12 | ||
| 3 | 5 | repos: | |
| 4 | 6 | - repo: https://github.com/pre-commit/pre-commit-hooks | |
| 5 | 7 | rev: v3.2.0 | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -116,9 +116,7 @@ def clone_project(project: Project) -> str: | |||
| 116 | 116 | return target_dir | |
| 117 | 117 | ||
| 118 | 118 | ||
| 119 | - def run_in_parallel[ | ||
| 120 | - T, U | ||
| 121 | - ]( | ||
| 119 | + def run_in_parallel[T, U]( | ||
| 122 | 120 | func: Callable[[T], U], | |
| 123 | 121 | items: List[T], | |
| 124 | 122 | *, | |
@@ -516,7 +514,7 @@ def main(config, args) -> None: | |||
| 516 | 514 | "--dca", | |
| 517 | 515 | type=str, | |
| 518 | 516 | help="Name of a DCA run that built all the projects. Can be repeated, with sources taken from all provided runs, " | |
| 519 | - "the last provided ones having priority", | ||
| 517 | + "the last provided ones having priority", | ||
| 520 | 518 | action="append", | |
| 521 | 519 | ) | |
| 522 | 520 | parser.add_argument( | |
0 commit comments