Fix error: Unusable type signature for overload of graphql.schema.SchemaTraverser::depthFirst #4147 - #4165
Merged
dondonz merged 1 commit intoDec 7, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…emaTraverser::depthFirst graphql-java#4147 I found the problematic overload in SchemaTraverser and updated its public API to accept the correct visitor type, ensuring it’s usable outside the class. This removes the unusable public signature that referenced the private TraverserDelegateVisitor type. All existing internal calls (which pass new TraverserDelegateVisitor(...)) still work because that class implements TraverserVisitor<GraphQLSchemaElement>. Summary: - Changed SchemaTraverser.depthFirst(Traverser, TraverserDelegateVisitor, ...) to use TraverserVisitor<GraphQLSchemaElement> instead, and adjusted the helper accordingly. - Public API is now usable by callers without referencing a private inner class; no behavior change for existing internal usage.
bbakerman
approved these changes
Nov 11, 2025
bbakerman
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found the problematic overload in SchemaTraverser and updated its public API to accept the correct visitor type, ensuring it’s usable outside the class.
This removes the unusable public signature that referenced the private TraverserDelegateVisitor type. All existing internal calls (which pass new TraverserDelegateVisitor(...)) still work because that class implements TraverserVisitor.
Summary:
Contribution by Gittensor, learn more at https://gittensor.io/