All fields removed from object/interface via field visibility transformer which is reachable via additional types - #4203
Merged
andimarek merged 2 commits intoJan 7, 2026
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Test Results 327 files ±0 327 suites ±0 5m 6s ⏱️ -2s Results for commit de1a152. ± Comparison against base commit 021fe1b. This pull request removes 213 and adds 191 tests. Note that renamed tests count towards both. ?
, expected: combo-\"\\\b\f\n\r\t, #4]
__schema { types { fields { args { type { name fields { name }}}}}}
__schema { types { fields { type { name fields { name }}}}}
__schema { types { inputFields { type { inputFields { name }}}}}
__schema { types { interfaces { fields { type { interfaces { name } } } } } }
__schema { types { name} }
__type(name : "t") { name }
a1: __schema { types { name} }
a1: __type(name : "t") { name }
…
graphql.AssertTest ‑ assertFalse with different number of error args but false does not throw assertions [toRun: <graphql.AssertTest$__spock_feature_0_21prov0_closure23@14823f76 delegate=graphql.AssertTest@6c6333cd owner=graphql.AssertTest@6c6333cd thisObject=graphql.AssertTest@6c6333cd resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1, #0] graphql.AssertTest ‑ assertFalse with different number of error args but false does not throw assertions [toRun: <graphql.AssertTest$__spock_feature_0_21prov0_closure24@1442f788 delegate=graphql.AssertTest@6c6333cd owner=graphql.AssertTest@6c6333cd thisObject=graphql.AssertTest@6c6333cd resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1 arg2, #1] graphql.AssertTest ‑ assertFalse with different number of error args but false does not throw assertions [toRun: <graphql.AssertTest$__spock_feature_0_21prov0_closure25@113e13f9 delegate=graphql.AssertTest@6c6333cd owner=graphql.AssertTest@6c6333cd thisObject=graphql.AssertTest@6c6333cd resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1 arg2 arg3, #2] graphql.AssertTest ‑ assertFalse with different number of error args throws assertions [toRun: <graphql.AssertTest$__spock_feature_0_20prov0_closure20@10643593 delegate=graphql.AssertTest@6c6333cd owner=graphql.AssertTest@6c6333cd thisObject=graphql.AssertTest@6c6333cd resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1, #0] graphql.AssertTest ‑ assertFalse with different number of error args throws assertions [toRun: <graphql.AssertTest$__spock_feature_0_20prov0_closure21@f91da5e delegate=graphql.AssertTest@6c6333cd owner=graphql.AssertTest@6c6333cd thisObject=graphql.AssertTest@6c6333cd resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1 arg2, #1] graphql.AssertTest ‑ assertFalse with different number of error args throws assertions [toRun: <graphql.AssertTest$__spock_feature_0_20prov0_closure22@eca6a74 delegate=graphql.AssertTest@6c6333cd owner=graphql.AssertTest@6c6333cd thisObject=graphql.AssertTest@6c6333cd resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1 arg2 arg3, #2] graphql.AssertTest ‑ assertNotNull with different number of error args throws assertions [toRun: <graphql.AssertTest$__spock_feature_0_5prov0_closure3@158f4cfe delegate=graphql.AssertTest@6c6333cd owner=graphql.AssertTest@6c6333cd thisObject=graphql.AssertTest@6c6333cd resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1, #0] graphql.AssertTest ‑ assertNotNull with different number of error args throws assertions [toRun: <graphql.AssertTest$__spock_feature_0_5prov0_closure4@3f702946 delegate=graphql.AssertTest@6c6333cd owner=graphql.AssertTest@6c6333cd thisObject=graphql.AssertTest@6c6333cd resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1 arg2, #1] graphql.AssertTest ‑ assertNotNull with different number of error args throws assertions [toRun: <graphql.AssertTest$__spock_feature_0_5prov0_closure5@10823d72 delegate=graphql.AssertTest@6c6333cd owner=graphql.AssertTest@6c6333cd thisObject=graphql.AssertTest@6c6333cd resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1 arg2 arg3, #2] graphql.AssertTest ‑ assertNotNull with different number of error args with non null does not throw assertions [toRun: <graphql.AssertTest$__spock_feature_0_6prov0_closure6@7e744f43 delegate=graphql.AssertTest@6c6333cd owner=graphql.AssertTest@6c6333cd thisObject=graphql.AssertTest@6c6333cd resolveStrategy=0 directive=0 parameterTypes=[class java.lang.Object] maximumNumberOfParameters=1 bcw=null>, expectedMessage: error arg1, #0] … graphql.schema.fetching.LambdaFetchingSupportTest ‑ different class loaders induce certain behaviours ♻️ This comment has been updated with latest results. |
Sorry, something went wrong.
…rmer (for input object types)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the case of all fields removed from an object/interface via field visibility transformer, which is still referenced via additional types, the validation would fail with
This fix ensures that the whole object is deleted if all fields are deleted, hence preventing this validation error.