🐛 Fix type annotation in `SQLModel.__new__`, avoid explicitly returni… · hellow554/sqlmodel@5da82e2 · GitHub

1. hellow554
2. sqlmodel

Repository navigation

• Code
• Pull requests
• Actions
• Projects
• Security and quality
• Insights

Commit 5da82e2

Browse filesBrowse the repository at this point in the historyBrowse files

carljm

authored

🐛 Fix type annotation in SQLModel.__new__, avoid explicitly returning Any (fastapi#1846)

1 parent 9a44fc4 commit 5da82e2
Copy full SHA for 5da82e2

1 file changed

+3-1Lines changed: 3 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• sqlmodel
  • main.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎sqlmodel/main.py‎

Copy file name to clipboardExpand all lines: sqlmodel/main.py

+3-1Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -814,7 +814,9 @@ class SQLModel(BaseModel, metaclass=SQLModelMetaclass, registry=default_registry
814	814	__allow_unmapped__ = True # https://docs.sqlalchemy.org/en/20/changelog/migration_20.html#migration-20-step-six
815	815	model_config = SQLModelConfig(from_attributes=True)
816	816
817		- def __new__(cls, *args: Any, **kwargs: Any) -> Any:
	817	+ # Typing spec says `__new__` returning `Any` overrides normal constructor
	818	+ # behavior, but a missing annotation does not:
	819	+ def __new__(cls, *args: Any, **kwargs: Any): # type: ignore[no-untyped-def]
818	820	new_object = super().__new__(cls)
819	821	# SQLAlchemy doesn't call __init__ on the base class when querying from DB
820	822	# Ref: https://docs.sqlalchemy.org/en/14/orm/constructors.html

0 commit comments

Comments

0 (0)