simple and blunt fix for BiVariableMap memory leak - #9331
Draft
matthias-fratz-bsz wants to merge 1 commit into
Draft
simple and blunt fix for BiVariableMap memory leak#9331matthias-fratz-bsz wants to merge 1 commit into
matthias-fratz-bsz wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This introduces an attribute SHARING_INSTANCE_VARIABLES to control whether instance variables are accessible via the embedding interface. It is disabled by default and has a clear warning that enabling it will lead to a memory leak unless cleaned up manually.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces an attribute SHARING_INSTANCE_VARIABLES to control whether instance variables are accessible via the embedding interface. It is disabled by default and has a clear warning that enabling it will lead to a memory leak unless cleaned up manually.
This is incomplete; I haven't adjusted the testcase yet. The testcase would now need to test the different behaviors with SHARING_INSTANCE_VARIABLES enabled and disabled, respectively. However, I think the code already shows the "simple and blunt" way of fixing the #8527 memory leak.