Commit 6696d1d
tools: improve error handling in node_mksnapshot
PR-URL: #59437
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>1 parent 3e4b1e7 commit 6696d1d
1 file changed
Lines changed: 9 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -66,8 +66,16 @@ int BuildSnapshot(int argc, char* argv[]) { | |||
| 66 | 66 | std::vector<std::string>(argv, argv + argc), | |
| 67 | 67 | node::ProcessInitializationFlags::kGeneratePredictableSnapshot); | |
| 68 | 68 | ||
| 69 | + if (result->exit_code() != 0) { | ||
| 70 | + for (const std::string& error : result->errors()) { | ||
| 71 | + std::cerr << error << "\n"; | ||
| 72 | + } | ||
| 73 | + std::cerr << "node_mksnapshot failed with exit code " << result->exit_code() | ||
| 74 | + << "\n"; | ||
| 75 | + return static_cast<int>(result->exit_code()); | ||
| 76 | + } | ||
| 77 | + | ||
| 69 | 78 | CHECK(!result->early_return()); | |
| 70 | - CHECK_EQ(result->exit_code(), 0); | ||
| 71 | 79 | ||
| 72 | 80 | std::string out_path; | |
| 73 | 81 | std::optional<std::string_view> builder_script_path = std::nullopt; | |
0 commit comments