FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: replace FIXED_ONE_BYTE_STRING with Environment-cached strings · nodejs/node@abecdcb · GitHub

/ node Public

Commit abecdcb

Browse files
iknoom
authored and
targos
committed
src: replace FIXED_ONE_BYTE_STRING with Environment-cached strings
PR-URL: #59891 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
1 parent 213188e commit abecdcb

4 files changed

Lines changed: 8 additions & 13 deletions

File tree

‎src/node_realm.cc‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,8 +72,7 @@ void Realm::CreateProperties() {
7272
CHECK(primordials->IsObject());
7373
set_primordials(primordials.As<Object>());
7474

75-
Local<String> prototype_string =
76-
FIXED_ONE_BYTE_STRING(isolate(), "prototype");
75+
Local<String> prototype_string = env_->prototype_string();
7776

7877
#define V(EnvPropertyName, PrimordialsPropertyName) \
7978
{ \

‎src/node_sqlite.cc‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1232,9 +1232,7 @@ void DatabaseSync::CustomFunction(const FunctionCallbackInfo<Value>& args) {
12321232
argc = -1;
12331233
} else {
12341234
Local<Value> js_len;
1235-
if (!fn->Get(env->context(),
1236-
FIXED_ONE_BYTE_STRING(env->isolate(), "length"))
1237-
.ToLocal(&js_len)) {
1235+
if (!fn->Get(env->context(), env->length_string()).ToLocal(&js_len)) {
12381236
return;
12391237
}
12401238
argc = js_len.As<Int32>()->Value();
@@ -1465,7 +1463,7 @@ void DatabaseSync::CreateSession(const FunctionCallbackInfo<Value>& args) {
14651463

14661464
Local<Object> options = args[0].As<Object>();
14671465

1468-
Local<String> table_key = FIXED_ONE_BYTE_STRING(env->isolate(), "table");
1466+
Local<String> table_key = env->table_string();
14691467
bool hasIt;
14701468
if (!options->HasOwnProperty(env->context(), table_key).To(&hasIt)) {
14711469
return;

‎src/node_webstorage.cc‎

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -738,11 +738,10 @@ static void Initialize(Local<Object> target,
738738

739739
Local<FunctionTemplate> length_getter =
740740
FunctionTemplate::New(isolate, StorageLengthGetter);
741-
ctor_tmpl->PrototypeTemplate()->SetAccessorProperty(
742-
FIXED_ONE_BYTE_STRING(isolate, "length"),
743-
length_getter,
744-
Local<FunctionTemplate>(),
745-
DontDelete);
741+
ctor_tmpl->PrototypeTemplate()->SetAccessorProperty(env->length_string(),
742+
length_getter,
743+
Local<FunctionTemplate>(),
744+
DontDelete);
746745

747746
SetProtoMethod(isolate, ctor_tmpl, "clear", Clear);
748747
SetProtoMethodNoSideEffect(isolate, ctor_tmpl, "getItem", GetItem);

‎src/stream_wrap.cc‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,8 +84,7 @@ void LibuvStreamWrap::Initialize(Local<Object> target,
8484
sw->InstanceTemplate()->Set(env->oncomplete_string(), v8::Null(isolate));
8585
sw->InstanceTemplate()->Set(FIXED_ONE_BYTE_STRING(isolate, "callback"),
8686
v8::Null(isolate));
87-
sw->InstanceTemplate()->Set(FIXED_ONE_BYTE_STRING(isolate, "handle"),
88-
v8::Null(isolate));
87+
sw->InstanceTemplate()->Set(env->handle_string(), v8::Null(isolate));
8988

9089
sw->Inherit(AsyncWrap::GetConstructorTemplate(env));
9190

0 commit comments

Comments
 (0)
Back | FazBrowse Home | New Git URL