FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: avoid unnecessary string -> `char*` -> string round trips · nodejs/node@eb99eec · GitHub

/ node Public

Commit eb99eec

Browse files
addaleax
authored and
targos
committed
src: avoid unnecessary string -> char* -> string round trips
In these places we can just generate `std::string` directly, so there's no need to convert to an intermediate C string. PR-URL: #60055 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
1 parent c1f1dbd commit eb99eec

6 files changed

Lines changed: 10 additions & 12 deletions

File tree

‎src/inspector/protocol_helper.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ inline std::unique_ptr<v8_inspector::StringBuffer> ToInspectorString(
1919
inline protocol::String ToProtocolString(v8::Isolate* isolate,
2020
v8::Local<v8::Value> value) {
2121
Utf8Value buffer(isolate, value);
22-
return *buffer;
22+
return buffer.ToString();
2323
}
2424

2525
} // namespace node::inspector

‎src/node_blob.cc‎

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -442,11 +442,9 @@ void Blob::StoreDataObject(const FunctionCallbackInfo<Value>& args) {
442442
Utf8Value type(isolate, args[3]);
443443

444444
binding_data->store_data_object(
445-
std::string(*key, key.length()),
445+
key.ToString(),
446446
BlobBindingData::StoredDataObject(
447-
BaseObjectPtr<Blob>(blob),
448-
length,
449-
std::string(*type, type.length())));
447+
BaseObjectPtr<Blob>(blob), length, type.ToString()));
450448
}
451449

452450
// Note: applying the V8 Fast API to the following function does not produce
@@ -486,7 +484,7 @@ void Blob::GetDataObject(const FunctionCallbackInfo<Value>& args) {
486484
Utf8Value key(isolate, args[0]);
487485

488486
BlobBindingData::StoredDataObject stored =
489-
binding_data->get_data_object(std::string(*key, key.length()));
487+
binding_data->get_data_object(key.ToString());
490488
if (stored.blob) {
491489
Local<Value> type;
492490
if (!String::NewFromUtf8(isolate,

‎src/node_contextify.cc‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -284,10 +284,10 @@ ContextifyContext* ContextifyContext::New(Local<Context> v8_context,
284284
options->allow_code_gen_wasm);
285285

286286
Utf8Value name_val(env->isolate(), options->name);
287-
ContextInfo info(*name_val);
287+
ContextInfo info(name_val.ToString());
288288
if (!options->origin.IsEmpty()) {
289289
Utf8Value origin_val(env->isolate(), options->origin);
290-
info.origin = *origin_val;
290+
info.origin = origin_val.ToString();
291291
}
292292

293293
ContextifyContext* result;

‎src/node_errors.h‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -276,12 +276,12 @@ inline void THROW_ERR_REQUIRE_ASYNC_MODULE(
276276
if (!parent_filename.IsEmpty() && parent_filename->IsString()) {
277277
Utf8Value utf8(env->isolate(), parent_filename);
278278
message += "\n From ";
279-
message += utf8.out();
279+
message += utf8.ToStringView();
280280
}
281281
if (!filename.IsEmpty() && filename->IsString()) {
282282
Utf8Value utf8(env->isolate(), filename);
283283
message += "\n Requiring ";
284-
message += +utf8.out();
284+
message += utf8.ToStringView();
285285
}
286286
THROW_ERR_REQUIRE_ASYNC_MODULE(env, message.c_str());
287287
}

‎src/node_messaging.cc‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1368,7 +1368,7 @@ std::unique_ptr<TransferData> JSTransferable::TransferOrClone() const {
13681368
}
13691369
Utf8Value deserialize_info_str(env()->isolate(), deserialize_info);
13701370
if (*deserialize_info_str == nullptr) return {};
1371-
return std::make_unique<Data>(*deserialize_info_str,
1371+
return std::make_unique<Data>(deserialize_info_str.ToString(),
13721372
Global<Value>(env()->isolate(), data));
13731373
}
13741374

‎src/quic/defs.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ bool SetOption(Environment* env,
3939
if (!object->Get(env->context(), name).ToLocal(&value)) return false;
4040
if (!value->IsUndefined()) {
4141
Utf8Value utf8(env->isolate(), value);
42-
options->*member = *utf8;
42+
options->*member = utf8.ToString();
4343
}
4444
return true;
4545
}

0 commit comments

Comments
 (0)
Back | FazBrowse Home | New Git URL