node-api: make napi_delete_reference use node_api_basic_env · nodejs/node@f006a14 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 119k

• Code
• Issues 632
• Pull requests 749
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit f006a14

Browse filesBrowse the repository at this point in the historyBrowse files

JeetuSuthar

authored and

targos

committed

node-api: make napi_delete_reference use node_api_basic_env

PR-URL: #59684 Refs: #59583 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Vladimir Morozov <vmorozov@microsoft.com>

1 parent 647c332 commit f006a14
Copy full SHA for f006a14

2 files changed

+3-2Lines changed: 3 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• src
  • js_native_api.h
  • js_native_api_v8.cc

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎src/js_native_api.h‎

Copy file name to clipboardExpand all lines: src/js_native_api.h

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -352,7 +352,7 @@ napi_create_reference(napi_env env,
352	352
353	353	// Deletes a reference. The referenced value is released, and may
354	354	// be GC'd unless there are other references to it.
355		- NAPI_EXTERN napi_status NAPI_CDECL napi_delete_reference(napi_env env,
	355	+ NAPI_EXTERN napi_status NAPI_CDECL napi_delete_reference(node_api_basic_env env,
356	356	napi_ref ref);
357	357
358	358	// Increments the reference count, optionally returning the resulting count.

Collapse file

‎src/js_native_api_v8.cc‎

Copy file name to clipboardExpand all lines: src/js_native_api_v8.cc

+2-1Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -2773,7 +2773,8 @@ napi_status NAPI_CDECL napi_create_reference(napi_env env,
2773	2773	// there are other references to it.
2774	2774	// For a napi_reference returned from `napi_wrap`, this must be called in the
2775	2775	// finalizer.
2776		- napi_status NAPI_CDECL napi_delete_reference(napi_env env, napi_ref ref) {
	2776	+ napi_status NAPI_CDECL napi_delete_reference(node_api_basic_env env,
	2777	+ napi_ref ref) {
2777	2778	// Omit NAPI_PREAMBLE and GET_RETURN_STATUS because V8 calls here cannot throw
2778	2779	// JS exceptions.
2779	2780	CHECK_ENV(env);

0 commit comments

Comments

0 (0)