Repository navigation
Commit 85735cb
feat(linter/unicorn): implement no-confusing-array-with rule (#23638)
Implements unicorn/no-confusing-array-with, which flags two ways
Array#with() calls can silently misbehave:
A literal negative index (array.with(-1, value)). Unlike
slice()/splice(), with() treats a negative index as an offset from the
end of the array, which is easy to assume incorrectly.
.length used as the index (array.with(array.length, value)), which is
always out of bounds and always produces a RangeError / unintended
result, since valid indices run 0 .. length - 1.
---------
Co-authored-by: Cameron <cameron.clark@hey.com>1 parent e703120 commit 85735cb
7 files changed
Lines changed: 469 additions & 1 deletion
File tree
- apps/oxlint/src-js/package
- crates/oxc_linter/src
- generated
- rules/unicorn
- snapshots
- npm/oxlint
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1530,6 +1530,7 @@ export interface DummyRuleMap { | |||
| 1530 | 1530 | "unicorn/no-array-sort"?: RuleNoConfig | [AllowWarnDeny, NoArraySort]; | |
| 1531 | 1531 | "unicorn/no-await-expression-member"?: RuleNoConfig; | |
| 1532 | 1532 | "unicorn/no-await-in-promise-methods"?: RuleNoConfig; | |
| 1533 | + "unicorn/no-confusing-array-with"?: RuleNoConfig; | ||
| 1533 | 1534 | "unicorn/no-console-spaces"?: RuleNoConfig; | |
| 1534 | 1535 | "unicorn/no-document-cookie"?: RuleNoConfig; | |
| 1535 | 1536 | "unicorn/no-empty-file"?: RuleNoConfig; | |
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -512,6 +512,7 @@ pub(crate) mod unicorn { | |||
| 512 | 512 | pub mod no_array_sort; | |
| 513 | 513 | pub mod no_await_expression_member; | |
| 514 | 514 | pub mod no_await_in_promise_methods; | |
| 515 | + pub mod no_confusing_array_with; | ||
| 515 | 516 | pub mod no_console_spaces; | |
| 516 | 517 | pub mod no_document_cookie; | |
| 517 | 518 | pub mod no_empty_file; | |
0 commit comments