typing: allow union types for instance_of - #1385
Merged
hynek merged 5 commits intoDec 15, 2024
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Tiiiiin, is this fixableeeee? tests/typing_example.py:231: error: Incompatible types in assignment (expression has type "UnionType", variable has type "int | C | str")
[assignment]
kk: int | C | str = attr.ib(
^
Found 1 error in 1 file (checked 1 source file)
Or are we doing typing bankruptcy (aka Any)? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
I played around with this a little. I don't think the type system can do this. The overload should be: @overload
def instance_of(type: UnionType) -> _ValidatorType[Any]: ...
|
Sorry, something went wrong.
hynek
force-pushed
the
instance-of-union
branch
from
82f4087 to
275bb9c
Compare
December 15, 2024 05:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1336