Do not presume "xmp" info simply because "XML:com.adobe.xmp" info exists - #8173
Merged
hugovk merged 1 commit intoJun 27, 2024
Merged
Do not presume "xmp" info simply because "XML:com.adobe.xmp" info exists#8173hugovk merged 1 commit into
hugovk merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Thank you, with the past and this pull request together - everything will be fine :) |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#8069 changed ImageOps.exif_transpose() so that when updating a PNG image's im.info["XML:com.adobe.xmp"], it would update the newly added im.info["xmp"] as well.
However, #8171 (comment) has pointed out that our code shouldn't presume that the user didn't manually set im.info["XML:com.adobe.xmp"] themselves, in which case im.info["xmp"] might be absent.