FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

futures-util portable-atomic feature, use it in futures unordered by tommasoclini · Pull Request #3007 · rust-lang/futures-rs · GitHub

  1. rust-lang
  2. futures-rs

Repository navigation

futures-util portable-atomic feature, use it in futures unordered - #3007

Merged
taiki-e merged 10 commits into
rust-lang:masterfrom
tommasoclini:portable_atomic_futures_unordered
Jul 12, 2026
ConversationCommits (10)ChecksFiles changed
Merged

futures-util portable-atomic feature, use it in futures unordered#3007
taiki-e merged 10 commits into
rust-lang:masterfrom
tommasoclini:portable_atomic_futures_unordered

Conversation

tommasoclini commented Apr 21, 2026

Copy link
Copy Markdown
Contributor

Solves #2953 for FuturesUnordered.

portable-atomic and portable-atomic-util types are not used in the public API, this makes necessary making a copy of the ArcWake trait in futures_unordered/task.rs that can use portable-atomic-util's types.

rustbot added the A-stream Area: futures::stream label Apr 21, 2026
tommasoclini force-pushed the portable_atomic_futures_unordered branch from 5349eed to b9a0027 Compare April 22, 2026 14:10

tommasoclini commented Apr 22, 2026

Copy link
Copy Markdown
Contributor Author

How should I fix the no_std thumbv6m-none-eabi runner?

tommasoclini marked this pull request as ready for review April 25, 2026 10:03
rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 25, 2026

tommasoclini commented May 1, 2026

Copy link
Copy Markdown
Contributor Author

Any help on getting the no-std runner to succeed?

tommasoclini marked this pull request as draft May 6, 2026 19:58
rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 6, 2026
tommasoclini mentioned this pull request May 24, 2026
Open

tommasoclini commented May 30, 2026

Copy link
Copy Markdown
Contributor Author

Hi, has anyone taken a look at this? @renkenono, @taiki-e?

This comment has been minimized.

Sign in to view
taiki-e reviewed Jun 4, 2026
View reviewed changes
Comment thread futures-util/Cargo.toml Resolved
Comment thread futures-util/Cargo.toml Resolved

tommasoclini commented Jun 5, 2026

Copy link
Copy Markdown
Contributor Author

@taiki-e thank you for your help with getting this pr to pass CI

tommasoclini marked this pull request as ready for review June 5, 2026 19:06
rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 5, 2026

tommasoclini commented Jun 21, 2026

Copy link
Copy Markdown
Contributor Author

Is this going to get merged before another merge conflict?

taiki-e requested changes Jun 21, 2026
View reviewed changes
Comment thread futures-util/Cargo.toml Resolved
Comment thread futures-util/Cargo.toml Resolved
Comment thread futures-util/src/stream/mod.rs Resolved
Comment thread futures-util/Cargo.toml Resolved
rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 21, 2026

tommasoclini commented Jun 21, 2026

Copy link
Copy Markdown
Contributor Author

what could the miri fail be caused by?

taiki-e commented Jun 21, 2026

Copy link
Copy Markdown
Member

what could the miri fail be caused by?

It's an upstream bug: rust-lang/miri#5122

tommasoclini commented Jun 21, 2026

Copy link
Copy Markdown
Contributor Author

are all the changes I made correct?

tommasoclini commented Jul 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Hi, is there still a chance that this is going to get merged?

taiki-e reviewed Jul 12, 2026
View reviewed changes

taiki-e left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. CI failure should be fixed by rebase.

View changes since this review

rustbot commented Jul 12, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

tommasoclini commented Jul 12, 2026

Copy link
Copy Markdown
Contributor Author

Sorry I just clicked sync fork but maybe I should have done something else instead

tommasoclini requested a review from taiki-e July 12, 2026 18:17
taiki-e approved these changes Jul 12, 2026
View reviewed changes

taiki-e left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks!

View changes since this review

taiki-e merged commit b28a6ad into rust-lang:master Jul 12, 2026
25 checks passed
rustbot mentioned this pull request Jul 12, 2026
Closed
taiki-e mentioned this pull request Jul 18, 2026
Merged
taiki-e pushed a commit that referenced this pull request Jul 18, 2026
Add portable-atomic-alloc feature and use it in FuturesUnordered (#3007)
8ae794f

taiki-e commented Jul 18, 2026

Copy link
Copy Markdown
Member

Published in 0.3.33.

markharding pushed a commit to futo-org/Harbor that referenced this pull request Oct 13, 2026
Update Rust crate futures to v0.3.34 (#1791)
a1a1c05 
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [futures](https://rust-lang.github.io/futures-rs) ([source](https://github.com/rust-lang/futures-rs)) | dependencies | patch | `0.3.32` → `0.3.34` |

---

### Release Notes

<details>
<summary>rust-lang/futures-rs (futures)</summary>

### [`v0.3.34`](https://github.com/rust-lang/futures-rs/blob/HEAD/CHANGELOG.md#0334---2026-08-11)

[Compare Source](rust-lang/futures-rs@0.3.33...0.3.34)

- Preserve cloned waker identity. ([#&#8203;3032](rust-lang/futures-rs#3032))
- Updato `syn` to 3. ([#&#8203;3028](rust-lang/futures-rs#3028))

### [`v0.3.33`](https://github.com/rust-lang/futures-rs/blob/HEAD/CHANGELOG.md#0333---2026-07-18)

[Compare Source](rust-lang/futures-rs@0.3.32...0.3.33)

- Fix `ReadLine`'s soundness issue regarding to exception safety. ([#&#8203;3020](rust-lang/futures-rs#3020))
- Fix unsound `Send` impl for `IterPinRef` and `Iter`. ([#&#8203;3003](rust-lang/futures-rs#3003))
- Fix stacked borrows violation in `compat01as03` implementation. ([#&#8203;3012](rust-lang/futures-rs#3012))
- Fix memory leak in `FuturesUnordered::IntoIter`. ([#&#8203;3005](rust-lang/futures-rs#3005))
- Add `portable-atomic-alloc` feature and use it in `FuturesUnordered`. ([#&#8203;3007](rust-lang/futures-rs#3007))
- Re-export `alloc::task::Wake`. ([#&#8203;3010](rust-lang/futures-rs#3010))
- Update `spin` to 0.12. ([#&#8203;3014](rust-lang/futures-rs#3014))

</details>

---

### Configuration

📅 **Schedule**: (UTC)

- Branch creation
  - "before 9am on tuesday"
- Automerge
  - At any time (no schedule defined)

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate CLI](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0NC4xMzMuMCIsInVwZGF0ZWRJblZlciI6IjQ0LjEzMy4wIiwidGFyZ2V0QnJhbmNoIjoiZGV2ZWxvcCIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJyZW5vdmF0ZSJdfQ==-->

Reviewed-on: https://code.futo.org/harbor/harbor/pulls/1791
Reviewed-by: Thomas de Zeeuw <thomas@futo.org>
This was referenced Oct 22, 2026
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

taiki-e taiki-e approved these changes
+1 more reviewer
renkenono renkenono approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-stream Area: futures::stream S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL