FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

add cli support for --transform-key to support mode's like production… by serapath · Pull Request #1709 · browserify/browserify · GitHub

add cli support for --transform-key to support mode's like production… - #1709

Merged
1 commit merged into
browserify:masterfrom
serapath-contribution:master
Apr 4, 2017
Merged

1 commit merged into
browserify:masterfrom
serapath-contribution:master

Conversation

serapath commented Apr 4, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

…/staging/etc..

Details see: #1706 (comment)

serapath commented Apr 4, 2017

Copy link
Copy Markdown
Contributor Author

Can this be merged anyway even though tests are failing?
This seems to be not related to my pull request at all.

Only bin/advanced.txt, readme.markdown and bin/args.js were touched.
In bin/args.js it's just one more command line option - so i don't see how this can possibly responsible for the breaking test.

serapath commented Apr 4, 2017

Copy link
Copy Markdown
Contributor Author

Maybe it would be even better to name it --mode or short -m instead, because --transform-key is kind of long.

Copy link
Copy Markdown
Contributor Author

@substack another 2 pull request to fix a problem with dependencies that do not specify the alternative --transform-key. They affect browserify and module-deps.

This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant


Back | FazBrowse Home | New Git URL