feat: initial support for Temporal equality (#8007) · vitest-dev/vitest@52bd789 · GitHub

vitest-dev / vitest Public

• Notifications You must be signed in to change notification settings
• Fork 2.1k
• Star 17.2k

• Code
• Issues 338
• Pull requests 18
• Discussions
• Actions
• Projects
• Security and quality 7
• Insights

Additional navigation options

Commit 52bd789

Browse filesBrowse the repository at this point in the historyBrowse files

dirkluijk

authored

feat: initial support for Temporal equality (#8007)

1 parent 69ca8b8 commit 52bd789
Copy full SHA for 52bd789

4 files changed

+69Lines changed: 69 additions & 0 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• packages/expect/src
  • jest-utils.ts
• pnpm-lock.yaml
• test/core
  • package.json
  • test
    • expect.test.ts

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎packages/expect/src/jest-utils.ts‎

Copy file name to clipboardExpand all lines: packages/expect/src/jest-utils.ts

+10Lines changed: 10 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -159,6 +159,16 @@ function eq(
159	159	// RegExps are compared by their source patterns and flags.
160	160	case '[object RegExp]':
161	161	return a.source === b.source && a.flags === b.flags
	162	+ case '[object Temporal.Instant]':
	163	+ case '[object Temporal.ZonedDateTime]':
	164	+ case '[object Temporal.PlainDateTime]':
	165	+ case '[object Temporal.PlainDate]':
	166	+ case '[object Temporal.PlainTime]':
	167	+ case '[object Temporal.PlainYearMonth]':
	168	+ case '[object Temporal.PlainMonthDay]':
	169	+ return a.equals(b)
	170	+ case '[object Temporal.Duration]':
	171	+ return a.toString() === b.toString()
162	172	}
163	173	if (typeof a !== 'object' || typeof b !== 'object') {
164	174	return false

Collapse file

‎pnpm-lock.yaml‎

Copy file name to clipboardExpand all lines: pnpm-lock.yaml

+15Lines changed: 15 additions & 0 deletions

Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Collapse file

‎test/core/package.json‎

Copy file name to clipboardExpand all lines: test/core/package.json

+1Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -30,6 +30,7 @@
30	30	"react": "^19.1.0",
31	31	"react-18": "npm:react@18.3.1",
32	32	"sweetalert2": "^11.21.2",
	33	+ "temporal-polyfill": "~0.3.0",
33	34	"tinyrainbow": "catalog:",
34	35	"tinyspy": "^1.1.1",
35	36	"url": "^0.11.4",

Collapse file

‎test/core/test/expect.test.ts‎

Copy file name to clipboardExpand all lines: test/core/test/expect.test.ts

+43Lines changed: 43 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -1,5 +1,6 @@
1	1	import type { Tester } from '@vitest/expect'
2	2	import { getCurrentTest } from '@vitest/runner'
	3	+ import { Temporal } from 'temporal-polyfill'
3	4	import { describe, expect, expectTypeOf, test, vi } from 'vitest'
4	5
5	6	describe('expect.soft', () => {
@@ -346,3 +347,45 @@ describe('iterator', () => {
346	347	expect(a).not.toStrictEqual(b)
347	348	})
348	349	})
	350	+
	351	+ describe('Temporal equality', () => {
	352	+ describe.each([
	353	+ ['Instant', ['2025-01-01T00:00:00.000Z', '2026-01-01T00:00:00.000Z']],
	354	+ ['ZonedDateTime', ['2025-01-01T00:00:00+01:00[Europe/Amsterdam]', '2025-01-01T00:00:00+01:00[Europe/Paris]']],
	355	+ ['PlainDateTime', ['2025-01-01T00:00:00.000', '2026-01-01T00:00:00.000']],
	356	+ ['PlainDate', ['2025-01-01', '2026-01-01']],
	357	+ ['PlainTime', ['15:00:00.000', '16:00:00.000']],
	358	+ ['PlainYearMonth', ['2025-01', '2026-01']],
	359	+ ['PlainMonthDay', ['01-01', '02-01']],
	360	+ ] as const)('of $className', (className, [first, second]) => {
	361	+ test('returns true when equal', () => {
	362	+ const a = Temporal[className].from(first)
	363	+ const b = Temporal[className].from(first)
	364	+
	365	+ expect(a).toStrictEqual(b)
	366	+ })
	367	+
	368	+ test('returns false when not equal', () => {
	369	+ const a = Temporal[className].from(first)
	370	+ const b = Temporal[className].from(second)
	371	+
	372	+ expect(a).not.toStrictEqual(b)
	373	+ })
	374	+ })
	375	+
	376	+ describe('of Duration', () => {
	377	+ test('returns true when .toString() is equal', () => {
	378	+ const a = Temporal.Duration.from('P1M')
	379	+ const b = Temporal.Duration.from('P1M')
	380	+
	381	+ expect(a).toStrictEqual(b)
	382	+ })
	383	+
	384	+ test('returns true when .toString() is not equal', () => {
	385	+ const a = Temporal.Duration.from('PT1M')
	386	+ const b = Temporal.Duration.from('PT60S')
	387	+
	388	+ expect(a).not.toStrictEqual(b)
	389	+ })
	390	+ })
	391	+ })

0 commit comments

Comments

0 (0)