fix(coverage): istanbul provider to not use Vite preserved query para… · vitest-dev/vitest@a05d48c · GitHub

vitest-dev / vitest Public

• Notifications You must be signed in to change notification settings
• Fork 2.1k
• Star 17.2k

• Code
• Issues 338
• Pull requests 19
• Discussions
• Actions
• Projects
• Security and quality 7
• Insights

Additional navigation options

Commit a05d48c

Browse filesBrowse the repository at this point in the historyBrowse files

AriPerkkio

authored

fix(coverage): istanbul provider to not use Vite preserved query params (#7939)

1 parent ef6ef54 commit a05d48c
Copy full SHA for a05d48c

1 file changed

+9-2Lines changed: 9 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• packages/coverage-istanbul/src
  • provider.ts

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎packages/coverage-istanbul/src/provider.ts‎

Copy file name to clipboardExpand all lines: packages/coverage-istanbul/src/provider.ts

+9-2Lines changed: 9 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -61,7 +61,14 @@ export class IstanbulCoverageProvider extends BaseCoverageProvider<ResolvedCover
61	61	}
62	62
63	63	onFileTransform(sourceCode: string, id: string, pluginCtx: any): { code: string; map: any } | undefined {
64		- if (!this.testExclude.shouldInstrument(id)) {
	64	+ // Istanbul/babel cannot instrument CSS - e.g. Vue imports end up here.
	65	+ // File extension itself is .vue, but it contains CSS.
	66	+ // e.g. "Example.vue?vue&type=style&index=0&scoped=f7f04e08&lang.css"
	67	+ if (id.endsWith('.css')) {
	68	+ return
	69	+ }
	70	+
	71	+ if (!this.testExclude.shouldInstrument(removeQueryParameters(id))) {
65	72	return
66	73	}
67	74
@@ -199,7 +206,7 @@ export class IstanbulCoverageProvider extends BaseCoverageProvider<ResolvedCover
199	206	}
200	207
201	208	// Make sure file is not served from cache so that instrumenter loads up requested file coverage
202		- await transform(`${filename}?v=${cacheKey}`)
	209	+ await transform(`${filename}?cache=${cacheKey}`)
203	210	const lastCoverage = this.instrumenter.lastFileCoverage()
204	211	coverageMap.addFileCoverage(lastCoverage)
205	212

0 commit comments

Comments

0 (0)