fix(browser): hide injected data-testid attributes (#9503) · vitest-dev/vitest@c8d2c41 · GitHub

vitest-dev / vitest Public

• Notifications You must be signed in to change notification settings
• Fork 1.9k
• Star 17k

• Code
• Issues 322
• Pull requests 62
• Discussions
• Actions
• Projects
• Security and quality 7
• Insights

Additional navigation options

Commit c8d2c41

Browse filesBrowse the repository at this point in the historyBrowse files

sheremet-va

authored

fix(browser): hide injected data-testid attributes (#9503)

1 parent e1b9512 commit c8d2c41
Copy full SHA for c8d2c41

2 files changed

+18Lines changed: 18 additions & 0 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• packages/pretty-format/src/plugins/lib
  • markup.ts
• test/browser/test
  • snapshot.test.ts

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎packages/pretty-format/src/plugins/lib/markup.ts‎

Copy file name to clipboardExpand all lines: packages/pretty-format/src/plugins/lib/markup.ts

+10Lines changed: 10 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -23,6 +23,16 @@ export function printProps(
23	23	return keys
24	24	.map((key) => {
25	25	const value = props[key]
	26	+ // hidden injected value that should not be printed
	27	+ if (
	28	+ typeof value === 'string'
	29	+ && value[0] === '_'
	30	+ && value.startsWith('__vitest_')
	31	+ && value.match(/__vitest_\d+__/)
	32	+ ) {
	33	+ return ''
	34	+ }
	35	+
26	36	let printed = printer(value, config, indentationNext, depth, refs)
27	37
28	38	if (typeof value !== 'string') {

Collapse file

‎test/browser/test/snapshot.test.ts‎

Copy file name to clipboardExpand all lines: test/browser/test/snapshot.test.ts

+8Lines changed: 8 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -12,3 +12,11 @@ test('file snapshot', async () => {
12	12	await expect('my snapshot content')
13	13	.toMatchFileSnapshot('./__snapshots__/custom/my_snapshot')
14	14	})
	15	+
	16	+ test('vitest attribute is hidden', () => {
	17	+ const div = document.createElement('div')
	18	+ div.setAttribute('data-testid', '__vitest_1__')
	19	+ expect(div).toMatchInlineSnapshot(`
	20	+ <div />
	21	+ `)
	22	+ })

0 commit comments

Comments

0 (0)