Added NullHandlers to all loggers to preven "No handler" messages · coolcoding/GitPython@aa0ccea · GitHub

coolcoding / GitPython Public

forked from gitpython-developers/GitPython

• Notifications You must be signed in to change notification settings
• Fork 0
• Star 0

• Code
• Pull requests
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit aa0ccea

Browse filesBrowse the repository at this point in the historyBrowse files

James Nowell

committed

Added NullHandlers to all loggers to preven "No handler" messages

When the code is run without setting up loggers, the loggers have no handlers for the emitted messages. The logging module displays: `No handlers could be found for logger "git.cmd"` on the console. By adding a NullHandler (a no-op) the message disappears, and doesn't affect logging when other handlers are configured.

1 parent 640d150 commit aa0ccea
Copy full SHA for aa0ccea

5 files changed

+5Lines changed: 5 additions & 0 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• git
  • cmd.py
  • config.py
  • objects
    • commit.py
    • submodule
      • base.py
      • root.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎git/cmd.py‎

Copy file name to clipboardExpand all lines: git/cmd.py

+1Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -44,6 +44,7 @@
44	44	'output_stream')
45	45
46	46	log = logging.getLogger('git.cmd')
	47	+ log.addHandler(logging.NullHandler())
47	48
48	49	__all__ = ('Git', )
49	50

Collapse file

‎git/config.py‎

Copy file name to clipboardExpand all lines: git/config.py

+1Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -32,6 +32,7 @@
32	32
33	33
34	34	log = logging.getLogger('git.config')
	35	+ log.addHandler(logging.NullHandler())
35	36
36	37
37	38	class MetaParserBuilder(abc.ABCMeta):

Collapse file

‎git/objects/commit.py‎

Copy file name to clipboardExpand all lines: git/objects/commit.py

+1Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -34,6 +34,7 @@
34	34	import logging
35	35
36	36	log = logging.getLogger('git.objects.commit')
	37	+ log.addHandler(logging.NullHandler())
37	38
38	39	__all__ = ('Commit', )
39	40

Collapse file

‎git/objects/submodule/base.py‎

Copy file name to clipboardExpand all lines: git/objects/submodule/base.py

+1Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -43,6 +43,7 @@
43	43
44	44
45	45	log = logging.getLogger('git.objects.submodule.base')
	46	+ log.addHandler(logging.NullHandler())
46	47
47	48
48	49	class UpdateProgress(RemoteProgress):

Collapse file

‎git/objects/submodule/root.py‎

Copy file name to clipboardExpand all lines: git/objects/submodule/root.py

+1Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -13,6 +13,7 @@
13	13	__all__ = ["RootModule", "RootUpdateProgress"]
14	14
15	15	log = logging.getLogger('git.objects.submodule.root')
	16	+ log.addHandler(logging.NullHandler())
16	17
17	18
18	19	class RootUpdateProgress(UpdateProgress):

0 commit comments

Comments

0 (0)