FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Include absoluteRuntime in babel preset docs by iddan · Pull Request #5847 · react/create-react-app · GitHub

  1. react
  2. create-react-app

Repository navigation

Include absoluteRuntime in babel preset docs - #5847

Merged
ianschmitz merged 3 commits into
react:masterfrom
iddan:master
Apr 4, 2020
ConversationCommits (3)ChecksFiles changed
Merged

Include absoluteRuntime in babel preset docs#5847
ianschmitz merged 3 commits into
react:masterfrom
iddan:master

Conversation

iddan commented Nov 17, 2018

Copy link
Copy Markdown
Contributor

Documented babel-preset-react-app absoluteRuntime option

Babel preset absoluteRuntime docs
b809b36 
Documented babel-preset-react-app absoluteRuntime option
iddan mentioned this pull request Nov 17, 2018
Closed
Timer added this to the 2.1.x milestone Nov 18, 2018
mrmckeb self-assigned this Dec 9, 2018

mrmckeb commented Dec 9, 2018

Copy link
Copy Markdown
Contributor

Thanks for this @iddan. Out of interest, what was the motivation for this PR? Was it an issue you faced yourself? And if so, why did you need to modify this setting?

Thanks!

iddan commented Dec 9, 2018

Copy link
Copy Markdown
Contributor Author

If I remember correctly I stumbled upon it while trying to integrate Storybook

mrmckeb suggested changes Dec 9, 2018
View reviewed changes

mrmckeb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks @iddan, two comments here - but looks good.

By the way, Storybook now works with create-react-app (including TypeScript and CSS modules (Sass included) without a custom config.

Comment thread packages/babel-preset-react-app/README.md Outdated
Comment thread packages/babel-preset-react-app/README.md

thallada commented Dec 31, 2018

Copy link
Copy Markdown

I think this should be merged! It turns out that this plugin was causing the contenthash for my JS bundles to change when building the exact same code between two different directories. And I didn't know about it because minification was stripping out the absolute paths from the final bundle. I'm not sure why absoluteRuntime needs to be true anyways, perhaps it should default to false instead?

See: webpack/webpack#1155 and webpack/webpack#7179

iansu modified the milestones: 2.1.x, 3.x Mar 10, 2019
Update packages/babel-preset-react-app/README.md
8b70df8 
Co-Authored-By: Brody McKee <mrmckeb@users.noreply.github.com>

iddan commented Apr 1, 2020

Copy link
Copy Markdown
Contributor Author

Why was this not merged?

ianschmitz modified the milestones: 3.x, 3.4.2 Apr 4, 2020
ianschmitz requested a review from mrmckeb April 4, 2020 23:31
ianschmitz changed the title Babel preset absoluteRuntime docs Include absoluteRuntime in babel preset docs Apr 4, 2020
ianschmitz merged commit c7352c7 into react:master Apr 4, 2020

ianschmitz commented Apr 4, 2020

Copy link
Copy Markdown
Contributor

Sorry this got missed. Thanks @iddan.

lock Bot locked and limited conversation to collaborators Apr 15, 2020
ianschmitz modified the milestones: 3.5, 4.0 May 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

ianschmitz Awaiting requested review from ianschmitz
iansu Awaiting requested review from iansu
petetnt Awaiting requested review from petetnt
mrmckeb Awaiting requested review from mrmckeb

Assignees

mrmckeb

Labels

CLA Signed tag: documentation

Projects

None yet

Milestone

4.0

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL