Repository navigation
Bump React Hooks ESLint plugin to 4.0.0 - #8939
Merged
ianschmitz merged 3 commits intoMay 4, 2020
Merged
ianschmitz merged 3 commits into
ianschmitz merged 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
gaearon
requested review from
ianschmitz,
iansu,
mrmckeb and
petetnt
as code owners
May 1, 2020 16:29
mrmckeb
approved these changes
May 2, 2020
ianschmitz
approved these changes
May 3, 2020
Copy link
Copy Markdown
Contributor
|
Thanks Dan! @iansu, this would be good to reference in the release notes when we get to it to set expectations of the false positives. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: https://github.com/facebook/react/blob/master/packages/eslint-plugin-react-hooks/CHANGELOG.md
Note some of these will likely cause false positives:
People who get them will likely complain because it's really annoying. But we think the change itself is worth it and it's a bitter pill we need to swallow now rather than prolong it. The workaround, as always, is to disable-line the ones that are false positives and, ideally, rename them in code.