FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fixes to password policy validation by kevinthecheung · Pull Request #2227 · firebase/firebase-admin-node · GitHub

/ firebase-admin-node Public

Fixes to password policy validation - #2227

Merged
kevinthecheung merged 5 commits into
masterfrom
kc-passwd-policy
Jun 27, 2023
ConversationCommits (5)ChecksFiles changed
Merged

Fixes to password policy validation#2227
kevinthecheung merged 5 commits into
masterfrom
kc-passwd-policy

Conversation

kevinthecheung commented Jun 27, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Reorder checks so that you can pass undefined to use defaults
  • Fix some 'undefined' comparisons

kevinthecheung marked this pull request as ready for review June 27, 2023 20:45
pragatimodi and others added 2 commits June 27, 2023 13:49
feat(auth): Add TotpInfo field to UserRecord (#2197)
6a9a002 
* Adding TotpInfo to userRecord

* Changing type from `any` to `unknown` for type safety.

* Addressing feedback
Merge branch 'master' into kc-passwd-policy
64af292
kevinthecheung requested review from lahirumaramba and removed request for prameshj June 27, 2023 20:54

pragatimodi commented Jun 27, 2023

Copy link
Copy Markdown
Contributor

LGTM, thank you for finding these!

kevinthecheung merged commit 64f0336 into master Jun 27, 2023
kevinthecheung deleted the kc-passwd-policy branch June 27, 2023 23:51
roblo1801 mentioned this pull request May 17, 2024
Open
X-oss-byte mentioned this pull request Jun 11, 2024
Closed
5twelve mentioned this pull request Aug 8, 2024
Open
This was referenced Aug 20, 2024
Closed
Closed
Closed
This was referenced Aug 28, 2024
Closed
Closed
Closed
Closed
This was referenced Sep 4, 2024
Closed
Closed
Closed
This was referenced Sep 13, 2024
Closed
Closed
Closed
This was referenced Sep 24, 2024
Closed
Closed
Closed
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lahirumaramba Awaiting requested review from lahirumaramba
1 more reviewer
pragatimodi pragatimodi approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL