Remove unneeded F401 "Unused import" suppressions · gitpython-developers/GitPython@31bc8a4 · GitHub

gitpython-developers / GitPython Public

• Notifications You must be signed in to change notification settings
• Fork 989
• Star 5.2k

• Code
• Issues 8
• Pull requests 2
• Discussions
• Actions
• Security and quality 34
• Insights

Additional navigation options

Commit 31bc8a4

Browse filesBrowse the repository at this point in the historyBrowse files

EliahKagan

committed

Remove unneeded F401 "Unused import" suppressions

In git.types. It appears Ruff, unlike flake8, recognizes "import X as X" to mean that "X" should not be considered unused, even when it appears outside a .pyi type stub file where that notation is more commonly used. Those imports in git.types may benefit from being changed in some way that uses a syntax whose intent is clearer in context, and depending on how that is done it may even be necessary to bring back suppressions. If so, they can be written more specifically. (For now, changing them would express more than is known about what names that are only present in git.types becuase it imports them should continue to be imported, should be considered conceptually public, or should be condered suitable for use within GitPython.)

1 parent 6318eea commit 31bc8a4
Copy full SHA for 31bc8a4

1 file changed

+3-3Lines changed: 3 additions & 3 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• git
  • types.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎git/types.py‎

Copy file name to clipboardExpand all lines: git/types.py

+3-3Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -3,7 +3,7 @@
3	3
4	4	import os
5	5	import sys
6		- from typing import ( # noqa: F401
	6	+ from typing import (
7	7	Any,
8	8	Callable,
9	9	Dict,
@@ -17,15 +17,15 @@
17	17	)
18	18
19	19	if sys.version_info >= (3, 8):
20		- from typing import ( # noqa: F401
	20	+ from typing import (
21	21	Literal,
22	22	Protocol,
23	23	SupportsIndex as SupportsIndex,
24	24	TypedDict,
25	25	runtime_checkable,
26	26	)
27	27	else:
28		- from typing_extensions import ( # noqa: F401
	28	+ from typing_extensions import (
29	29	Literal,
30	30	Protocol,
31	31	SupportsIndex as SupportsIndex,

0 commit comments

Comments

0 (0)