Use same code style for all logging without placeholders · gitpython-developers/GitPython@4b86993 · GitHub

gitpython-developers / GitPython Public

• Notifications You must be signed in to change notification settings
• Fork 992
• Star 5.2k

• Code
• Issues 7
• Pull requests 2
• Discussions
• Actions
• Security and quality 34
• Insights

Additional navigation options

Commit 4b86993

Browse filesBrowse the repository at this point in the historyBrowse files

EliahKagan

committed

Use same code style for all logging without placeholders

When logging with only a msg argument, it is a full literal message rather than a format string (as it is when there are placeholders). Thus both `...("%s", text)` and `...(text)`, where `...` is a logging method or function, are equally good code styles, provided `text` really is known to behave the same as `str(text)`. The latter style, `...(text)`, was used in all logging calls, both in the git module and in the test suite, except one. This changes the one outlier from `...("%s", text)` to `...(text)` for stylistic consistency and to avoid giving the false impression that there is something special about that call.

1 parent 5faf621 commit 4b86993
Copy full SHA for 4b86993

1 file changed

+1-1Lines changed: 1 addition & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test
  • test_index.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/test_index.py‎

Copy file name to clipboardExpand all lines: test/test_index.py

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -174,7 +174,7 @@ def _decode(stdout):
174	174	except UnicodeDecodeError:
175	175	pass
176	176	except LookupError as error:
177		- _logger.warning("%s", str(error)) # Message already says "Unknown encoding:".
	177	+ _logger.warning(str(error)) # Message already says "Unknown encoding:".
178	178
179	179	# Assume UTF-8. If invalid, substitute Unicode replacement characters.
180	180	return stdout.decode("utf-8", errors="replace")

0 commit comments

Comments

0 (0)