Add graceful handling of expected exceptions in `fuzz_submodule.py` · gitpython-developers/GitPython@7b684cd · GitHub

gitpython-developers / GitPython Public

• Notifications You must be signed in to change notification settings
• Fork 989
• Star 5.2k

• Code
• Issues 8
• Pull requests 2
• Discussions
• Actions
• Security and quality 34
• Insights

Additional navigation options

Commit 7b684cd

Browse filesBrowse the repository at this point in the historyBrowse files

DaveLak

committed

Add graceful handling of expected exceptions in fuzz_submodule.py

Fixes: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=69350 **`IsADirectoryError`** Fuzzer provided input data can sometimes produce filenames that look like directories and raise `IsADirectoryError` exceptions which crash the fuzzer. This commit catches those cases and returns -1 to instruct libfuzzer that the inputs are not valuable to add to the corpus. **`FileExistsError`** Similar to the above, this is a possible exception case produced by the fuzzed data and not a bug so its handled the same.

1 parent 2345c1a commit 7b684cd
Copy full SHA for 7b684cd

1 file changed

+9-1Lines changed: 9 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• fuzzing/fuzz-targets
  • fuzz_submodule.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎fuzzing/fuzz-targets/fuzz_submodule.py‎

Copy file name to clipboardExpand all lines: fuzzing/fuzz-targets/fuzz_submodule.py

+9-1Lines changed: 9 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -67,7 +67,15 @@ def TestOneInput(data):
67	67	)
68	68	repo.index.commit(f"Removed submodule {submodule_name}")
69	69
70		- except (ParsingError, GitCommandError, InvalidGitRepositoryError, FileNotFoundError, BrokenPipeError):
	70	+ except (
	71	+ ParsingError,
	72	+ GitCommandError,
	73	+ InvalidGitRepositoryError,
	74	+ FileNotFoundError,
	75	+ FileExistsError,
	76	+ IsADirectoryError,
	77	+ BrokenPipeError,
	78	+ ):
71	79	return -1
72	80	except (ValueError, OSError) as e:
73	81	expected_messages = [

0 commit comments

Comments

0 (0)