This repository was archived by the owner on Aug 13, 2026. It is now read-only.
Fix: Removed EnableExactlyOnceDelivery from Builders - #1052
Merged
mmicatka merged 4 commits intoMar 9, 2022
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
mmicatka
marked this pull request as ready for review
March 9, 2022 15:57
maheshgattani
approved these changes
Mar 9, 2022
maheshgattani
approved these changes
Mar 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing EnableExactlyOnceDelivery from Subscriber builder + constructor, StreamingSubscriberConnection builder + constructor, and MessageDispatcher builder + constructor.
EnableExactlyOnceDelivery defaults to false, and is pulled from the streaming pull response in StreamingSubscriberConnection.StreamingPullResponseObserver.onResponse and is propagated to StreamingSubscriberConnection and MessageDispatcher.
Also added comments to the AckReplyConsumerWithResponse to be in line with AckReplyConsumer.