This repository was archived by the owner on Mar 9, 2026. It is now read-only.
fix: batch at most 1,000 ack ids per request - #802
Merged
acocuzzo merged 4 commits intoOct 8, 2022
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
acocuzzo
approved these changes
Oct 8, 2022
acocuzzo
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Will need to change expected calls in test_dispatcher splitting_large_payload acks and modacks tests from 3 to 6.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
1 more reviewer4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings parity with the java client. Allowing 2,500 ack ids in a single request can result in the request failing due to being too big.
Release-As: 2.13.10