Add a way to do case-insensitive sorting via file-contents-sorter. - #514
Merged
asottile merged 1 commit intoAug 27, 2020
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Julian
commented
Aug 27, 2020
Comment thread
pre_commit_hooks/file_contents_sorter.py
asottile
reviewed
Aug 27, 2020
Comment thread
pre_commit_hooks/file_contents_sorter.py
Outdated
Julian
force-pushed
the
case-insensitive-sorting
branch
from
8b671b7 to
5573426
Compare
August 27, 2020 01:49
asottile
force-pushed
the
case-insensitive-sorting
branch
from
5573426 to
9215818
Compare
August 27, 2020 01:53
asottile
approved these changes
Aug 27, 2020
asottile
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lol I cannot get https://pre-commit.ci done fast enough can I :) (pushed pre-commit run --all-files)
Sorry, something went wrong.
Julian
force-pushed
the
case-insensitive-sorting
branch
from
9215818 to
0c76025
Compare
August 27, 2020 01:55
Copy link
Copy Markdown
Contributor
Author
|
pfft so did I. Clearly pre-commit.ci should just be the PR submitter and maintainer racing to run pre-commit. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does nothing fancy (no case folding).
But does what I need in my case.
Comments welcome of course.