Updated string_decoder to v1.0.0 - #1714
Merged
feross merged 1 commit intoMay 27, 2017
Merged
feross merged 1 commit into
feross merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Tests pass with no issues. Are there are user-visible breaking changes? @mcollina Should this be semver minor or major, in your opinion? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
There are no visible breaking change. We bumped it in readable-stream with no breakage whatsoever. A minor release is ok. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
14.4.0 |
Sorry, something went wrong.
This was referenced May 29, 2021
This was referenced Jun 6, 2021
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As titled.