fix: corrects test for non-existent attribute (#1395) · QPC-github/python-bigquery@a80f436 · GitHub

QPC-github / python-bigquery Public

forked from googleapis/python-bigquery

• Notifications You must be signed in to change notification settings
• Fork 0
• Star 1

• Code
• Pull requests 4
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit a80f436

Browse filesBrowse the repository at this point in the historyBrowse files

chalmerlowe

authored

fix: corrects test for non-existent attribute (googleapis#1395)

* fix: corrects test for non-existent attribute * updates import statement to fix linting issue * updates a test to check for Python version * updates comments

1 parent 36c4a63 commit a80f436
Copy full SHA for a80f436

3 files changed

+8-3Lines changed: 8 additions & 3 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• google/cloud/bigquery
  • table.py
• samples/geography
  • requirements.txt
• tests/unit
  • test_table.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎google/cloud/bigquery/table.py‎

Copy file name to clipboardExpand all lines: google/cloud/bigquery/table.py

+2-1Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -40,10 +40,11 @@
40	40
41	41	try:
42	42	import shapely # type: ignore
	43	+ from shapely import wkt # type: ignore
43	44	except ImportError:
44	45	shapely = None
45	46	else:
46		- _read_wkt = shapely.wkt.loads
	47	+ _read_wkt = wkt.loads
47	48
48	49	import google.api_core.exceptions
49	50	from google.api_core.page_iterator import HTTPIterator

Collapse file

‎samples/geography/requirements.txt‎

Copy file name to clipboardExpand all lines: samples/geography/requirements.txt

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -10,7 +10,7 @@ db-dtypes==1.0.4
10	10	Fiona==1.8.22
11	11	geojson==2.5.0
12	12	geopandas===0.10.2; python_version == '3.7'
13		- geopandas==0.11.1; python_version >= '3.8'
	13	+ geopandas==0.12.1; python_version >= '3.8'
14	14	google-api-core==2.10.2
15	15	google-auth==2.13.0
16	16	google-cloud-bigquery==3.3.5

Collapse file

‎tests/unit/test_table.py‎

Copy file name to clipboardExpand all lines: tests/unit/test_table.py

+5-1Lines changed: 5 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -15,6 +15,7 @@
15	15	import datetime
16	16	import logging
17	17	import re
	18	+ from sys import version_info
18	19	import time
19	20	import types
20	21	import unittest
@@ -1969,7 +1970,10 @@ def test_to_geodataframe(self):
1969	1970	df = row_iterator.to_geodataframe(create_bqstorage_client=False)
1970	1971	self.assertIsInstance(df, geopandas.GeoDataFrame)
1971	1972	self.assertEqual(len(df), 0) # verify the number of rows
1972		- self.assertIsNone(df.crs)
	1973	+ if version_info.major == 3 and version_info.minor > 7:
	1974	+ assert not hasattr(df, "crs") # used with Python > 3.7
	1975	+ else:
	1976	+ self.assertIsNone(df.crs) # used with Python == 3.7
1973	1977
1974	1978
1975	1979	class TestRowIterator(unittest.TestCase):

0 commit comments

Comments

0 (0)