FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: enable complex resource ids in instantiate() by miraleung · Pull Request #159 · googleapis/api-common-java · GitHub

This repository was archived by the owner on Sep 27, 2023. It is now read-only.
/ api-common-java Public archive

fix: enable complex resource ids in instantiate() - #159

Merged
miraleung merged 1 commit into
masterfrom
fix/instantiate
Jul 1, 2020
ConversationCommits (1)ChecksFiles changed
Merged

fix: enable complex resource ids in instantiate()#159
miraleung merged 1 commit into
masterfrom
fix/instantiate

Conversation

miraleung commented Jun 30, 2020

Copy link
Copy Markdown
Contributor

Fixes #154.

miraleung requested a review from vam-google June 30, 2020 19:54
googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 30, 2020

codecov Bot commented Jun 30, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #159 into master will increase coverage by 0.33%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #159      +/-   ##
============================================
+ Coverage     64.09%   64.43%   +0.33%     
- Complexity      171      174       +3     
============================================
  Files            14       14              
  Lines           713      717       +4     
  Branches        118      120       +2     
============================================
+ Hits            457      462       +5     
+ Misses          220      219       -1     
  Partials         36       36
Impacted Files Coverage Δ Complexity Δ
...java/com/google/api/pathtemplate/PathTemplate.java 69.66% <100.00%> (+0.50%) 117.00 <0.00> (+3.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39612f1...a178f1a. Read the comment docs.

vam-google approved these changes Jul 1, 2020
View reviewed changes

vam-google left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

devchas commented Jul 1, 2020

Copy link
Copy Markdown

I just tested this out with a local build, and it seems to have fixed the problem. Thank you for the quick fix here! Any idea when this might make it into the next release. As mentioned in #154, we have another large body of work which depends on this feature, with a hard deadline in mid-July.

miraleung merged commit 955b8a7 into master Jul 1, 2020
miraleung deleted the fix/instantiate branch July 1, 2020 18:13
elharo reviewed Jul 1, 2020
View reviewed changes
Comment thread src/test/java/com/google/api/pathtemplate/PathTemplateTest.java
Truth.assertThat(match.get("foo")).isEqualTo("foo1");
Truth.assertThat(match.get("bar")).isEqualTo("bar2");
variables = template.vars();
System.out.println("DEL: vars: " + variables);

elharo Jul 1, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This shouldn't be here

Comment thread src/test/java/com/google/api/pathtemplate/PathTemplateTest.java
.containsExactly("foo", "bar", "zone_a", "zone_b", "zone_c", "cell1", "cell2");

pattern = "projects/{foo}_{bar}/zones/*";
template = PathTemplate.create(pattern);

elharo Jul 1, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

local variables probably shouldn't be reused

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
elharo elharo left review comments
vam-google vam-google approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

How to return PathTemplate with complex resource identifiers?

5 participants

Back | FazBrowse Home | New Git URL