This repository was archived by the owner on May 12, 2026. It is now read-only.
fix: allow unset/null privateKeyId for JwtCredentials - #336
Merged
chingor13 merged 4 commits intoAug 22, 2019
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## master #336 +/- ##
=========================================
Coverage ? 79.67%
Complexity ? 389
=========================================
Files ? 27
Lines ? 1761
Branches ? 183
=========================================
Hits ? 1403
Misses ? 262
Partials ? 96
Continue to review full report at Codecov.
|
Sorry, something went wrong.
chingor13
marked this pull request as ready for review
August 22, 2019 17:29
BenWhitehead
approved these changes
Aug 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #335
This was a regression from 0.16.2
Note that if you load Service Account Credentials from json, that field is required.