chore(tests): per-package system test timeouts - #18206
Draft
daniel-sanche wants to merge 35 commits into
Draft
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Code Review
This pull request increases the Kokoro build timeout to 6 hours and introduces a per-package timeout mechanism (defaulting to 35 minutes) using the timeout command in .kokoro/system.sh. It also adds tracking and reporting for timed-out packages, and triggers system tests across multiple packages. The reviewer feedback recommends declaring the pkg and timed_out variables as local at the top of the reap_parallel_results function in .kokoro/system.sh to prevent global namespace pollution and duplicate declarations.
Sorry, something went wrong.
Comment thread
.kokoro/system.sh
Comment thread
.kokoro/system.sh
Outdated
Comment thread
.kokoro/system.sh
Outdated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewerAt least 1 approving review is required to merge this pull request.
Assignees
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the recent push to parallelize system tests using background threads, it is now more likely that a test can get stuck and cause deadlock. We encountered this recently when the system tests in #18013 were running for 3 hours before hitting kokoro's limits and timing out. This was due to a deadlock in the sqlalchemy-spanner tests that was blocking the merge of our releases
This PR adds per-package timeouts, so individual packages won't run for longer than 1 hour
tests are currently blocked on #18230 (failing unit) and #18239 (timing out sqlalchemy tests)