test(secretmanager): add integration and unit parametrization to include OTel integration testing - #18217
Draft
chalmerlowe wants to merge 34 commits into
Draft
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…iding getattr(None)
…injection helpers
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Code Review
This pull request parameterizes the unit test session in noxfile.py to optionally install OpenTelemetry dependencies, but changes the test path to run all tests (including integration tests) when enabled, while deleting the dedicated integration session. The review feedback correctly points out that running integration tests in the unit session will cause CI failures due to missing credentials and recommends keeping unit tests restricted to tests/unit and restoring the separate integration session.
Sorry, something went wrong.
Comment thread
packages/google-cloud-secret-manager/noxfile.py
Outdated
…rsion in unit session
…shared setup helper
…ng-integration-tests
chalmerlowe
force-pushed
the
feat/otel-tracing-transport-logic
branch
3 times, most recently
from
0b26d1e to
2669ca4
Compare
August 28, 2026 13:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewerAssignees
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[WIP]