FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: add support of customTimeBefore and daysSinceCustomTime by athakor · Pull Request #396 · googleapis/java-storage · GitHub

/ java-storage Public

feat: add support of customTimeBefore and daysSinceCustomTime - #396

Merged
frankyn merged 5 commits into
googleapis:masterfrom
athakor:storage-olm
Aug 27, 2020
ConversationCommits (5)ChecksFiles changed
Merged

feat: add support of customTimeBefore and daysSinceCustomTime#396
frankyn merged 5 commits into
googleapis:masterfrom
athakor:storage-olm

Conversation

athakor commented Jun 26, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Towards #395

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 26, 2020
athakor requested review from JesseLovelace and frankyn June 26, 2020 13:44

codecov Bot commented Jun 26, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #396 into master will increase coverage by 0.02%.
The diff coverage is 68.00%.

@@             Coverage Diff              @@
##             master     #396      +/-   ##
============================================
+ Coverage     64.49%   64.52%   +0.02%     
+ Complexity      623      614       -9     
============================================
  Files            32       32              
  Lines          5199     5220      +21     
  Branches        501      505       +4     
============================================
+ Hits           3353     3368      +15     
- Misses         1687     1693       +6     
  Partials        159      159
Impacted Files Coverage Δ Complexity Δ
...main/java/com/google/cloud/storage/BucketInfo.java 83.97% <68.00%> (-0.42%) 86.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf94230...e03f8cb. Read the comment docs.

frankyn commented Jun 26, 2020

Copy link
Copy Markdown
Contributor

@jkwlui

frankyn added the status: blocked Resolving the issue is dependent on other work. label Jun 29, 2020
athakor added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 9, 2020
yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 9, 2020
athakor added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Jul 25, 2020
yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jul 25, 2020
athakor added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 5, 2020
yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 5, 2020
frankyn approved these changes Aug 12, 2020
View reviewed changes

frankyn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Hi @athakor,

Update: The Cloud Storage team has updated type of noncurrent_time_before and custom_time to be a Date format (YYYY-mm-dd) instead of DateTime.

Discovery document with updated documentation with respect to these fields:
https://www.googleapis.com/discovery/v1/apis/storage/v1/rest

This has been updated in the latest release dependency in PR (#457). Please update relevant documentation.

frankyn suggested changes Aug 12, 2020
View reviewed changes

frankyn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Hi @athakor,

Update: The Cloud Storage team has updated type of noncurrent_time_before and custom_time to be a Date format (YYYY-mm-dd) instead of DateTime.

Discovery document with updated documentation with respect to these fields:
https://www.googleapis.com/discovery/v1/apis/storage/v1/rest

This has been updated in the latest release dependency in PR (#457). Please update relevant documentation.

athakor commented Aug 13, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Hi @athakor,

Update: The Cloud Storage team has updated type of noncurrent_time_before and custom_time to be a Date format (YYYY-mm-dd) instead of DateTime.

Discovery document with updated documentation with respect to these fields:
https://www.googleapis.com/discovery/v1/apis/storage/v1/rest

This has been updated in the latest release dependency in PR (#457). Please update relevant documentation.

@frankyn That change has been already done also updated the relevant java doc.

frankyn removed the status: blocked Resolving the issue is dependent on other work. label Aug 24, 2020

athakor commented Aug 26, 2020

Copy link
Copy Markdown
Contributor Author

@jkwlui @JesseLovelace PTAL

JesseLovelace reviewed Aug 26, 2020
View reviewed changes
Comment thread google-cloud-storage/src/main/java/com/google/cloud/storage/BucketInfo.java Outdated
return matchesStorageClass;
}

/* Returns the date in RFC 3339 format with only the date part (for instance, "2013-01-15")*/

JesseLovelace Aug 26, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

End this with a period, i.e. "(for instance, "2013-01-15"). */"

athakor Aug 27, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

done

frankyn merged commit 1af8288 into googleapis:master Aug 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
JesseLovelace JesseLovelace left review comments
frankyn frankyn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL