FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: expose updateTime field of the bucket by athakor · Pull Request #449 · googleapis/java-storage · GitHub

/ java-storage Public

feat: expose updateTime field of the bucket - #449

Merged
frankyn merged 6 commits into
googleapis:masterfrom
athakor:storage-bucket-updateTime
Aug 5, 2020
ConversationCommits (6)ChecksFiles changed
Merged

feat: expose updateTime field of the bucket#449
frankyn merged 6 commits into
googleapis:masterfrom
athakor:storage-bucket-updateTime

Conversation

athakor commented Aug 4, 2020

Copy link
Copy Markdown
Contributor

Fixes #448

athakor requested a review from frankyn August 4, 2020 12:53
google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 4, 2020
athakor added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 4, 2020
yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 4, 2020

codecov Bot commented Aug 5, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #449 into master will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #449      +/-   ##
============================================
+ Coverage     63.12%   63.19%   +0.07%     
- Complexity      610      622      +12     
============================================
  Files            32       32              
  Lines          5133     5144      +11     
  Branches        490      491       +1     
============================================
+ Hits           3240     3251      +11     
  Misses         1729     1729              
  Partials        164      164
Impacted Files Coverage Δ Complexity Δ
...src/main/java/com/google/cloud/storage/Bucket.java 82.20% <100.00%> (+0.12%) 34.00 <0.00> (ø)
...main/java/com/google/cloud/storage/BucketInfo.java 82.01% <100.00%> (+0.27%) 86.00 <1.00> (+3.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ce82cc...6c2f688. Read the comment docs.

dmitry-fa approved these changes Aug 5, 2020
View reviewed changes

dmitry-fa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good!

frankyn merged commit f0e945e into googleapis:master Aug 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
frankyn frankyn approved these changes
dmitry-fa dmitry-fa approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Expose updateTime field of the bucket's

4 participants

Back | FazBrowse Home | New Git URL