FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

docs: refresh view samples by tswast · Pull Request #420 · googleapis/python-bigquery · GitHub

This repository was archived by the owner on Mar 6, 2026. It is now read-only.
/ python-bigquery Public archive

docs: refresh view samples - #420

Merged
tswast merged 1 commit into
googleapis:masterfrom
tswast:b173133642-view-samples
Dec 10, 2020
ConversationCommits (1)ChecksFiles changed
Merged

docs: refresh view samples#420
tswast merged 1 commit into
googleapis:masterfrom
tswast:b173133642-view-samples

Conversation

tswast commented Dec 7, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

These snippets are copied from snippets.py and refreshed
to include imports and client construction. Will follow up
with a PR to remove the redundant snippets once the docs
on cloud.google.com are updated.

I notice that the tests for these snippets have been skipped.
I believe that was due to a temporary rollout issue with
table update. If that actually is flakier than I thought, we
can more easily add retries or disable just updates in this
new structure.

python-bigquery/docs/snippets.py

Line 487 in 96a1c5b

def test_manage_views(client, to_delete):

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal issue 173133642 🦕

product-auto-label Bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Dec 7, 2020
google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 7, 2020
product-auto-label Bot added the samples Issues that are directly related to samples. label Dec 7, 2020

snippet-bot Bot commented Dec 7, 2020 •
edited
Loading

Copy link
Copy Markdown

Here is the summary of changes.

You added 11 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

tmatsuo commented Dec 8, 2020

Copy link
Copy Markdown
Contributor

Re: snippet-bot's comment

I guess you're moving samples under samples dir. The bot is warning because some region tags are referenced from the devsite doc. This will cause 404 errors on our devsite pages.

I think the correct course of action is to 1) duplicate the sample, 2) update devsite, then 3) remove the old tags.

tswast force-pushed the b173133642-view-samples branch from b80cd52 to 58f2d2d Compare December 8, 2020 16:38
tswast changed the title docs: move and refresh view samples docs: refresh view samples Dec 8, 2020
tswast marked this pull request as ready for review December 8, 2020 16:43
tswast requested a review from a team as a code owner December 8, 2020 16:43
tswast requested review from crwilcox, shollyman and steffnay and removed request for a team December 8, 2020 16:43

tswast commented Dec 8, 2020

Copy link
Copy Markdown
Contributor Author

Thanks @tmatsuo for looking. Yes, I am trying to move these samples. I'll try your suggested process.

docs: move and refresh view samples
8240434 
docs: restore old view snippets

remove relative imports

docs: fix missing space in comment

sort imports
tswast force-pushed the b173133642-view-samples branch from fa645bf to 8240434 Compare December 9, 2020 19:49
tswast merged commit 079b6a1 into googleapis:master Dec 10, 2020
tswast deleted the b173133642-view-samples branch December 10, 2020 23:05
tswast mentioned this pull request Dec 14, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

crwilcox Awaiting requested review from crwilcox
steffnay Awaiting requested review from steffnay
1 more reviewer
shollyman shollyman approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigquery Issues related to the googleapis/python-bigquery API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL