FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

docs: fix Shapely import in GEOGRAPHY sample by tswast · Pull Request #431 · googleapis/python-bigquery · GitHub

This repository was archived by the owner on Mar 6, 2026. It is now read-only.
/ python-bigquery Public archive

docs: fix Shapely import in GEOGRAPHY sample - #431

Merged
tswast merged 1 commit into
googleapis:masterfrom
tswast:b171804665-geography
Dec 9, 2020
ConversationCommits (1)ChecksFiles changed
Merged

docs: fix Shapely import in GEOGRAPHY sample#431
tswast merged 1 commit into
googleapis:masterfrom
tswast:b171804665-geography

Conversation

tswast commented Dec 9, 2020

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

tswast requested a review from a team as a code owner December 9, 2020 22:36
tswast requested review from busunkim96 and removed request for a team December 9, 2020 22:36
product-auto-label Bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Dec 9, 2020
google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 9, 2020
product-auto-label Bot added the samples Issues that are directly related to samples. label Dec 9, 2020
tswast requested a review from shollyman December 9, 2020 22:36
shollyman approved these changes Dec 9, 2020
View reviewed changes

shollyman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM assuming tests ok

tswast merged commit 96a1c5b into googleapis:master Dec 9, 2020
tswast deleted the b171804665-geography branch December 9, 2020 22:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
shollyman shollyman approved these changes
busunkim96 busunkim96 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigquery Issues related to the googleapis/python-bigquery API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL