This repository was archived by the owner on Mar 6, 2026. It is now read-only.
fix: disambiguate missing policy tags from explicitly unset policy tags - #983
Merged
gcf-merge-on-green[bot] merged 7 commits intoSep 24, 2021
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This was referenced Sep 22, 2021
plamut
suggested changes
Sep 23, 2021
plamut
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Looks good (with one minor nit), seems like we just need to adjust the type annotation and it should be good.
Sorry, something went wrong.
Comment thread
google/cloud/bigquery/schema.py
Outdated
Comment thread
google/cloud/bigquery/schema.py
Outdated
plamut
reviewed
Sep 24, 2021
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Looks good, except for a typo.
Edit: Just fixed it myself.
Sorry, something went wrong.
Comment thread
google/cloud/bigquery/schema.py
Outdated
plamut
approved these changes
Sep 24, 2021
judahrand
pushed a commit
to judahrand/python-bigquery
that referenced
this pull request
Sep 27, 2021
…gs (googleapis#983) Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-bigquery/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) Fixes googleapis#981 Fixes googleapis#982 Towards googleapis/python-bigquery-pandas#387 🦕
abdelmegahedgoogle
pushed a commit
to abdelmegahedgoogle/python-bigquery
that referenced
this pull request
Apr 17, 2023
…gs (googleapis#983) Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-bigquery/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) Fixes googleapis#981 Fixes googleapis#982 Towards googleapis/python-bigquery-pandas#387 🦕
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #981
Fixes #982
Towards googleapis/python-bigquery-pandas#387
🦕