This repository was archived by the owner on Jun 8, 2026. It is now read-only.
fix: remove error msg check from test_decimal_precision_limit for non emulator test - #647
Merged
vi3k6i5 merged 4 commits intoJun 15, 2021
Merged
vi3k6i5 merged 4 commits into
vi3k6i5 merged 4 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
… case in test_decimal_precision_limit
… case in test_decimal_precision_limit
asthamohta
approved these changes
Jun 15, 2021
This was referenced Apr 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed test_decimal_precision_limit to not check specific error msg and only check for exception class in non emulator test case.
Since googleapis/python-spanner#340 python spanner throws ValueError when decimal precision limit is not met. Corrected test case to expect the same exception to be raised.
fixes #645