Add syntax for subtraction type - #240
Draft
rvanvelzen wants to merge 1 commit into
Draft
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Sorry, something went wrong.
mvorisek
reviewed
Sep 8, 2024
Comment thread
tests/PHPStan/Parser/TypeParserTest.php
| ), | ||
| ], | ||
| [ | ||
| 'string~int~float', |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
One non-parentheised expression should not allow more than one ~ to prevent associativity ambiguity as not standartized not needed.
As you can see, currently float is even missing in the parsed type.
Sorry, something went wrong.
mvorisek
reviewed
Sep 8, 2024
Comment thread
tests/PHPStan/Parser/TypeParserTest.php
| Lexer::TOKEN_SUBTRACTION, | ||
| ], | ||
| [ | ||
| '(string&int)~float', |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
These cases should be tested:
- A|B~C (expected A|(B~C))
- A~B|C (expected (A~B)|C)
- A&B~C (expected syntax error?)
- A~B&C (expected syntax error?)
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a preliminary syntax implementation for subtraction type syntax.
Merging now isn't necessary because the work in phpstan-src is far from done. Any feedback is still appreciated though.