bookstack/api-scripts
Watch
3
[Star]
Fork You've already forked api-scripts
6
Code Issues Pull requests Activity

Added the Flutter/Dart example #12

Merged
chris-devel0per merged 6 commits from main into main 2023-10-31 17:40:40 +01:00
Conversation 3 Commits 6 Files changed 1 +4
[]
chris-devel0per commented 2023-10-30 14:28:40 +01:00 (Migrated from github.com)
Copy link

This contains the Flutter Example.

This contains the Flutter Example.
[]
ssddanbrown commented 2023-10-30 17:15:44 +01:00 (Migrated from github.com)
Copy link

Thanks for offering this @chris-devel0per, but to be honest I aim to keep the examples within this repo minimal and very simple to ease any required maintenance. Your app project is way larger than than anything I'd look to have here.
I am however happy to link to such larger projects via the readme, like you have added as part of this PR.

Therefore, I wouldn't look to merge this as-is, but if you could reduce it to just the readme addition I'd be happy to merge.

Thanks for offering this @chris-devel0per, but to be honest I aim to keep the examples within this repo minimal and very simple to ease any required maintenance. Your app project is way larger than than anything I'd look to have here. I am however happy to link to such larger projects via the readme, like you have added as part of this PR. Therefore, I wouldn't look to merge this as-is, but if you could reduce it to just the readme addition I'd be happy to merge.
[]
chris-devel0per commented 2023-10-30 20:24:59 +01:00 (Migrated from github.com)
Copy link

Yes, that's what I was thinking. I changed it and now only the Readme.md is changed

Yes, that's what I was thinking. I changed it and now only the Readme.md is changed
[]
ssddanbrown commented 2023-10-31 17:42:40 +01:00 (Migrated from github.com)
Copy link

Thanks @chris-devel0per! Now merged.
I had to squash the commits before merging, since otherwise it'd still include the addition and removal of all your project files, hope you don't mind!

Thanks @chris-devel0per! Now merged. I had to squash the commits before merging, since otherwise it'd still include the addition and removal of all your project files, hope you don't mind!
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
1 participant
[]
Notifications
[Subscribe]
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
bookstack/api-scripts!12
Write Preview
Loading
Add table
Rows
Columns
Cancel OK
Add a link
Url Description
Hint: With a URL in your clipboard, you can paste directly into the editor to create a link.
Cancel OK
Cancel Save
No description provided.