Update path-browserify to v1.0.0 - #1838

Eh, I hoped this update could get in as a semver-minor version
Any ETA for the release?

I will probably take a look if fixes could be backported to path-browserify@0.0.x.
@goto-bus-stop What do you think?

path methods now throw errors when called with arguments that are not
strings.

Do you have a specific case in mind, btw?

That's not applicable to all the methods, as e.g. "

• path.resolve threw on non-strings in 0.0.0.
• path.isAbsolute also likely threw as it called .charAt directly without any checks.
• path.normalize called .isAbsolute and also threw.
• path.join also contained a check.
• path.relative called .resolve and also threw.

The three methods that didn't throw were: .dirname(), .basename() and .extname().

What do you think of converting the input to string on those and releasing that as path-browserify@0.0.1?

The basename / extname / dirname methods didn't throw in 0.0.0:

[image]

I think doing a path-browserify release with the fixes and new features but without the additional checks would be fine

@goto-bus-stop Could I chat with you via IRC or Gitter about it?

Hey folks just wanted to reach out and see if there's anything I can do to help here

For posterity: my concerns above were adressed with a semver-patch version of path-browserify@0.x that backported some of the fixes in a compatible form, so having this update to @1.0.0 a semver-major is fine to me.

• __