![[]](https://github.githubassets.com/assets/platform-4ce65ae0bf273ce2.png){kind=link}
![[]](https://github.githubassets.com/assets/platform-dark-ac89fbf373737ed3.png){kind=link}
![[]](https://github.githubassets.com/assets/copilot-e2b89335a66dba00.png){kind=link}
![[]](https://github.githubassets.com/assets/copilot-dark-2b28403b6080e898.png){kind=link}
![[]](https://github.githubassets.com/assets/changelog-fd687bff072883b0.png){kind=link}
![[]](https://github.githubassets.com/assets/changelog-dark-b1c25ae971bd641b.png){kind=link}
![[]](https://github.githubassets.com/assets/universe-a98cd54821b27569.png){kind=link}
{{ message }}
Repository navigation
More items
feat: Transport logs error message for HTTP 413 responses - #7261
Merged
philippsuess merged 16 commits intoJan 27, 2026
Merged
philippsuess merged 16 commits into
philippsuess merged 16 commits into
Conversation
Copy link
Copy Markdown
Contributor
Implements error logging for HTTP 413 (Content Too Large) responses to help users understand why their envelopes are being rejected. The error message includes the envelope size in bytes and item types. Fixes #7248
Copy link
Copy Markdown
Contributor
Semver Impact of This PRMinor (new features) Changelog PreviewThis is how your changes will appear in the changelog. New Features
Bug Fixes
Internal Changes
Other
This preview updates automatically when you update the PR. |
Copy link
Copy Markdown
Contributor
|
Copy link
Copy Markdown
Codecov Report All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #7261 +/- ##
=============================================
- Coverage 85.050% 85.039% -0.012%
=============================================
Files 470 472 +2
Lines 28396 28414 +18
Branches 12464 12468 +4
=============================================
+ Hits 24151 24163 +12
- Misses 4199 4202 +3
- Partials 46 49 +3
... and 9 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
philippsuess
marked this pull request as ready for review
January 26, 2026 09:59
philippsuess
requested review from
itaybre,
noahsmartin and
philprime
as code owners
January 26, 2026 09:59
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Comment thread
Tests/SentryTests/Networking/SentryHttpTransportTests.swift
Resolved
Copy link
Copy Markdown
Contributor
Performance metrics
Baseline results on branch: mainStartup times
App size
Previous results on branch: feat/http-413-loggingStartup times
App size
|
[@philprime]
philprime
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Comment thread
Sources/Sentry/SentryHttpTransport.m
Resolved
Comment thread
Sources/Swift/Networking/SentryHttpTransportHttpStatusCodeLogger.swift
Resolved
andling Introduces a new Swift enum to replace magic numbers with named constants for HTTP status codes. The enum is accessible from both Swift and Objective-C and includes custom equality operators for seamless Int comparison without requiring .rawValue. All status codes include MDN documentation references. Updated SentryHttpTransportHttpStatusCodeLogger and its tests to use the enum, improving code readability and type safety.
P transport - Renamed SentryHttpStatusCodes to SentryHttpStatusCode (singular) for consistency - Added HTTP 201 Created and 400 Bad Request status codes - Updated SentryHttpTransport to use enum values for status code comparisons (200, 400, 429) - Added comprehensive test suite for enum equality operators - All equality operators support direct Int comparison without .rawValue Updated files: - SentryHttpStatusCode.swift (renamed from SentryHttpStatusCodes.swift) - SentryHttpTransport.m: Uses enum for 200, 400, and 429 status codes - SentryHttpTransportHttpStatusCodeLogger.swift: Updated enum references - Tests: Updated all test files to use renamed enum - Added SentryHttpStatusCodeTests.swift with 11 tests for equality and raw value verification
ests - Renamed raw value tests to status code value tests - Changed all but one test to use == operator instead of .rawValue - Kept one raw value test (testRawValue_shouldReturnCorrectInt) to verify rawValue works - All 12 tests passing
Changed from (200 == SentryHttpStatusCode.ok) to (SentryHttpStatusCode.ok == 200) for more natural reading order.
Copy link
Copy Markdown
Contributor
Author
|
@philprime, I added the HTTP status code enum. Please have another look |
Regenerated sdk_api.json to include the new SentryHttpStatusCode enum exposed to Objective-C via @objc annotation.
Removed @_spi(Private) and public modifiers from the equality operators. These operators are only needed within the module and don't need to be exposed as SPI.
[@philprime]
philprime
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Comment thread
Tests/SentryTests/Networking/SentryHttpStatusCodeTests.swift
Resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements error logging for HTTP 413 (Content Too Large) responses to help users understand why their envelopes are being rejected. When the SDK receives an HTTP 413 response, it now logs an error message.
Motivation and Context
Fixes #7248
Users need visibility into why their envelopes are being rejected by the server. HTTP 413 responses indicate the envelope is too large, but without detailed logging, it's difficult to diagnose which events or attachments are causing the issue.
This follows the Sentry SDK specification: https://develop.sentry.dev/sdk/expected-features/#dealing-with-network-failures
How did you test it?
Unit tests and tested with a sample app and capturing a message exceeding 1 MiB to double-check if Relay returns 413.
Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.