Shutdown cb arg can be undefined + always return null - #1082

Make shutdown consistent:

cb is optional in both function definitions
cb can get undefined as arg when no error occured
with no shutdown functions, return null instead of the return value of cb(), like the return value with shutdown functions.
with no shutdown functions, explicit pass of undefined to cb() for simpler typings of cb() to always have an argument.

[Go]

refactor(#1082): removed return value for `log4js.shutdown()`

richardhinkamp and others added 2 commits June 9, 2021 21:19

[@richardhinkamp]

Shutdown cb arg can be undefined + always return null

fc1ccbe

[@lamweili]

Merge branch 'master' into shutdown-type-consistent

49e301d

[@lamweili] lamweili added this to the 6.7.0 milestone Sep 2, 2022

[@lamweili]

lamweili merged commit 6a60294 into log4js-node:master Sep 2, 2022

lamweili added a commit that referenced this pull request Sep 3, 2022

[@lamweili]

refactor(#1082): removed return value for log4js.shutdown()

a8418a0

lamweili added a commit that referenced this pull request Sep 3, 2022

[@lamweili]

Merge pull request #1319 from log4js-node/refactor/log4js.shutdown() …

588e793

refactor(#1082): removed return value for `log4js.shutdown()`

Navigation Menu

Repository navigation

Shutdown cb arg can be undefined + always return null - #1082