fix(LoggingEvent): serde for `NaN`, `Infinity`, `-Infinity`, `undefined` - #1332

Supersedes PR #1188

Affected Components

Only affects clustering, multiprocessAppender, and tcpAppender.
These three will serialise() to String to transmit for the receiver to deserialise().

Code	Object (Input)	Serialised (Transmission)	Deserialised (Output)
`{"a": Number("abc")}`	`{"a": NaN}`	`{"a": "__LOG4JS_NaN__"}`	`{"a": NaN}`
`{"b": 1/0}`	`{"b": Infinity}`	`{"b": "__LOG4JS_Infinity__"}`	`{"b": Infinity}`
`{"c": -1/0}`	`{"c": -Infinity}`	`{"c": "__LOG4JS_-Infinity__"}`	`{"c": -Infinity}`
`[undefined]`	`[undefined]`	`["__LOG4JS_undefined__"]`	`[undefined]`

Compared to PR #1188, now the output matches exactly the input.

[Go]

ariable name)

lamweili added 3 commits October 1, 2022 18:37

[@lamweili]

fix(LoggingEvent): serde for NaN, Infinity, -Infinity, undefined

6f9c436

[@lamweili]

test(logLevelFilter): renamed test description with correct filenames

8b44497

[@lamweili]

refactor: typeof to check for undefined (because undefined can be a v …

ffa9e5e

ariable name)

[@lamweili] lamweili added the bug Something isn't working label Oct 1, 2022

[@lamweili] lamweili added this to the 6.7.0 milestone Oct 1, 2022

[@lamweili]

lamweili merged commit 570ef53 into master Oct 1, 2022

[@lamweili]

lamweili deleted the fix/serde branch October 1, 2022 10:57

This was referenced Oct 1, 2022

NaN needs to be handled here, otherwise JSON.stringfly will convert NaN to null below #1187

Closed

Fixes serialise() for NaN, Infinity, -Infinity and undefined #1188

Merged

Navigation Menu

Repository navigation

fix(LoggingEvent): serde for `NaN`, `Infinity`, `-Infinity`, `undefined` - #1332