[ Web Proxy ]
URL:
Viewing: https://github-redirect.dependabot.com/python/cpython/issues/31841 [Back]  [Original]
bpo-46998: Allow subclassing Any at runtime by hauntsaninja Pull Request #31841 python/cpython GitHub
Skip to content

Navigation Menu

Sign in
Search/
Sign in
Sign up

bpo-46998: Allow subclassing Any at runtime - #31841

Merged
JelleZijlstra merged 15 commits into
python:mainfrom
hauntsaninja:subclass-any
Apr 5, 2022
ConversationCommits(15)ChecksFiles changed
Merged

bpo-46998: Allow subclassing Any at runtime#31841
JelleZijlstra merged 15 commits into
python:mainfrom
hauntsaninja:subclass-any

Conversation

@hauntsaninja [@hauntsaninja]

@hauntsaninja [@hauntsaninja] hauntsaninja commented Mar 13, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor
[Go]
@hauntsaninja [@hauntsaninja]

hauntsaninja commented Mar 13, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

This PR also permits issubclass(X, Any). I don't actually have a use case for doing so, so happy to forbid it if people feel strongly.

The error in functools.singledispatch used to be TypeError: Invalid annotation for 'x'. typing.Any is not a class.. Since typing.Any is now a class, that isn't quite true. We could add a special case check in singledispatch against typing.Any if we think it's important to prevent its use. The dedicated tests for Any were added very recently, in #30050
[Go]
@hauntsaninja [@hauntsaninja]
hauntsaninja marked this pull request as ready for review March 13, 2022 08:54
JelleZijlstra [JelleZijlstra]
JelleZijlstra reviewed Mar 13, 2022
View reviewed changes
Comment thread Lib/test/test_typing.py Outdated Show resolved Hide resolved
Comment thread Lib/typing.py Show resolved Hide resolved
Comment thread Misc/NEWS.d/next/Library/2022-03-13-08-52-58.bpo-46998.cHh-9O.rst Outdated Show resolved Hide resolved
Comment thread Lib/test/test_functools.py
with self.assertRaisesRegex(TypeError, "Invalid first argument to "):
f.register(typing.List[float] | bytes, lambda arg: "typing.Union[typing.GenericAlias]")
with self.assertRaisesRegex(TypeError, "Invalid first argument to "):
f.register(typing.Any, lambda arg: "typing.Any")

@JelleZijlstra [@JelleZijlstra] JelleZijlstra Mar 13, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Hide comment]

This might be worth forbidding explicitly because the behavior could be quite unintuitive. Happy to leave that decision to the functools maintainer though.

[Go]

@AlexWaygood [@AlexWaygood] AlexWaygood Mar 30, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Hide comment]

@ambv, do you have any thoughts on the bits of this PR that touch singledispatch?

[Go]
Comment thread Lib/typing.py
@_SpecialForm
def Any(self, parameters):
class _AnyMeta(type):
def __instancecheck__(self, obj):

@JelleZijlstra [@JelleZijlstra] JelleZijlstra Mar 13, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Hide comment]

Should we even have this? isinstance(X, Any) is now a meaningful operation.

[Go]

@hauntsaninja [@hauntsaninja] hauntsaninja Mar 13, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Hide comment]

I'm fine with removing it (as this PR currently does for issubclass). Doing so would also allow us to get rid of the metaclass, which will help remove restrictions on what classes can inherit from Any.

My reasoning for keeping it is that isinstance is very commonly used, potentially by typing / Python novices, and isinstance(..., Any) doesn't correspond well to the notion of Any at type check time. Sophisticated users have workarounds available to them for the equivalent isinstance check.

[Go]
Comment thread Lib/typing.py Outdated Show resolved Hide resolved
Comment thread Lib/typing.py

@_SpecialForm
def Any(self, parameters):
class _AnyMeta(type):

@JelleZijlstra [@JelleZijlstra] JelleZijlstra Mar 13, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Hide comment]

The metaclass is unfortunate because it restricts what classes can double-inherit from Any (due to metaclass conflicts). Seems unavoidable though.

[Go]

@hauntsaninja [@hauntsaninja] hauntsaninja Mar 13, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Hide comment]

Not entirely unavoidable, if we were willing to give up on instancecheck (and repr), I'd say we could just remove the metaclass entirely

[Go]
@JelleZijlstra [@JelleZijlstra]

JelleZijlstra commented Mar 29, 2022

Copy link
Copy Markdown
Member

Planning to merge in a few days unless there's more discussion.
[Go]
JelleZijlstra [JelleZijlstra]
JelleZijlstra requested changes Mar 29, 2022
View reviewed changes

@JelleZijlstra [@JelleZijlstra] JelleZijlstra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Hide comment]

Looking at it again, I realize we should document this. Probably fine to just add a note like .. versionchanged: 3.11: Any can now be used as a base class.

[Go]
@bedevere-bot [@bedevere-bot]

bedevere-bot commented Mar 29, 2022

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be poked with soft cushions!
[Go]
@hauntsaninja [@hauntsaninja]

hauntsaninja commented Mar 30, 2022

Copy link
Copy Markdown
Contributor Author

a comment on this pull request containing the phrase I have made the requested changes; please review again
[Go]
@bedevere-bot [@bedevere-bot]

bedevere-bot commented Mar 30, 2022

Copy link
Copy Markdown

Thanks for making the requested changes!

@JelleZijlstra: please review the changes made to this pull request.
[Go]
merwok [merwok]
merwok reviewed Mar 30, 2022
View reviewed changes
Comment thread Doc/library/typing.rst Outdated
* :data:`Any` is compatible with every type.

.. versionchanged:: 3.11
:data:`Any` can now be used as a base class

@merwok [@merwok] merwok Mar 30, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Hide comment]

Can you add some explanation about the use cases?

This doesnt say why someone could want that, nor does the ticket, one has to hunt for the last message in the mailing list thread!

[Go]

@hauntsaninja [@hauntsaninja] hauntsaninja Mar 30, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Hide comment]

I added a sentence here. Let me know if I should make it longer; I tried to keep it short because this is a lot more niche than other things covered in typing.rst

[Go]

@AlexWaygood [@AlexWaygood] AlexWaygood Mar 30, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Hide comment]

I think adding one short example might be nice

[Go]

@JelleZijlstra [@JelleZijlstra] JelleZijlstra Mar 31, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Hide comment]

Not sure about this. On the one hand an example would be useful; on the other hand it risks putting too much emphasis on a pretty obscure use case.

[Go]

@hauntsaninja [@hauntsaninja] hauntsaninja Mar 31, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Hide comment]

Let's omit the example then (devguide says "err on the side of being succinct" for docs). I'm hoping to do some work on typing docs sometime soon, which might be a better home for such details.

[Go]

@AlexWaygood [@AlexWaygood] AlexWaygood Mar 31, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Hide comment]

Alrighty!

[Go]
@JelleZijlstra [@JelleZijlstra]
JelleZijlstra merged commit 5a4973e into python:main Apr 5, 2022
Closed
@hauntsaninja [@hauntsaninja]
hauntsaninja deleted the subclass-any branch April 26, 2022 03:09
@sobolevn [@sobolevn] sobolevn mentioned this pull request Aug 30, 2022
Merged
@mikelane [@mikelane] mikelane mentioned this pull request Oct 7, 2022
Merged
@kryzdof [@kryzdof] kryzdof mentioned this pull request Oct 11, 2022
Merged
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request Oct 27, 2022
mcepl [mcepl] @bmwiedemann [@bmwiedemann]
Update python-typing_extensions to version 4.4.0 / rev 16 via SR 1031001 …
2ce7d92 
https://build.opensuse.org/request/show/1031001
by user mcepl + dimstar_suse
- Clean specfile from old cruft.
- Requires Python 3.7+
- Fix testsuite: Must test as module; don't need multibuild.
- Update Summary and Description
- Update to version 4.4.0
  * Add `typing_extensions.Any` a backport of python 3.11's Any class which is
    subclassable at runtime. (backport from python/cpython#31841, by Shantanu
    and Jelle Zijlstra). Patch by James Hilton-Balfe (@Gobot1234).
  * Add initial support for TypeVarLike `default` parameter, PEP 696.
    Patch by Marc Mueller (@cdce8p).
  * Runtime support for PEP 698, adding `typing_extensions.override`. Patch by
    Jelle Zijlstra.
  * Add the `infer_variance` parameter to `TypeVar`, as specified in PEP 695.
    Patch by Jelle Zijlstra.
kraj pushed a commit to YoeDistro/poky that referenced this pull request Nov 2, 2022
@moto-timo [@moto-timo] @alexandrebelloni [@alexandrebelloni]
python3-typing-extensions: upgrade 4.3.0 -> 4.4.0 …
d149bba 
https://github.com/python/typing_extensions/blob/main/CHANGELOG.md#release-440-october-6-2022

Release 4.4.0 (October 6, 2022)

* Add typing_extensions.Any a backport of python 3.11's Any class
  which is subclassable at runtime. (backport from python/cpython#31841,
  by Shantanu and Jelle Zijlstra). Patch by James Hilton-Balfe
  (@Gobot1234).
* Add initial support for TypeVarLike default parameter, PEP 696.
  Patch by Marc Mueller (@cdce8p).
* Runtime support for PEP 698, adding typing_extensions.override.
  Patch by Jelle Zijlstra.
* Add the infer_variance parameter to TypeVar, as specified in PEP
  695. Patch by Jelle Zijlstra.

(From OE-Core rev: 0b8f212744f8de7e6b33ab02d042009eba462241)

Signed-off-by: Tim Orling <tim.orling@konsulko.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
kraj pushed a commit to YoeDistro/poky that referenced this pull request Nov 2, 2022
@moto-timo [@moto-timo] @kraj [@kraj]
python3-typing-extensions: upgrade 4.3.0 -> 4.4.0 …
f2f2c3f 
https://github.com/python/typing_extensions/blob/main/CHANGELOG.md#release-440-october-6-2022

Release 4.4.0 (October 6, 2022)

* Add typing_extensions.Any a backport of python 3.11's Any class
  which is subclassable at runtime. (backport from python/cpython#31841,
  by Shantanu and Jelle Zijlstra). Patch by James Hilton-Balfe
  (@Gobot1234).
* Add initial support for TypeVarLike default parameter, PEP 696.
  Patch by Marc Mueller (@cdce8p).
* Runtime support for PEP 698, adding typing_extensions.override.
  Patch by Jelle Zijlstra.
* Add the infer_variance parameter to TypeVar, as specified in PEP
  695. Patch by Jelle Zijlstra.

(From OE-Core rev: 0b8f212744f8de7e6b33ab02d042009eba462241)

Signed-off-by: Tim Orling <tim.orling@konsulko.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
kraj pushed a commit to YoeDistro/poky that referenced this pull request Nov 2, 2022
@moto-timo [@moto-timo] @alexandrebelloni [@alexandrebelloni]
python3-typing-extensions: upgrade 4.3.0 -> 4.4.0 …
47b21de 
https://github.com/python/typing_extensions/blob/main/CHANGELOG.md#release-440-october-6-2022

Release 4.4.0 (October 6, 2022)

* Add typing_extensions.Any a backport of python 3.11's Any class
  which is subclassable at runtime. (backport from python/cpython#31841,
  by Shantanu and Jelle Zijlstra). Patch by James Hilton-Balfe
  (@Gobot1234).
* Add initial support for TypeVarLike default parameter, PEP 696.
  Patch by Marc Mueller (@cdce8p).
* Runtime support for PEP 698, adding typing_extensions.override.
  Patch by Jelle Zijlstra.
* Add the infer_variance parameter to TypeVar, as specified in PEP
  695. Patch by Jelle Zijlstra.

(From OE-Core rev: 34c8f1eac66ae770d64eaa854b1f263848210773)

Signed-off-by: Tim Orling <tim.orling@konsulko.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
kraj pushed a commit to YoeDistro/poky that referenced this pull request Nov 4, 2022
@moto-timo [@moto-timo] @alexandrebelloni [@alexandrebelloni]
python3-typing-extensions: upgrade 4.3.0 -> 4.4.0 …
61402c7 
* Add SUMMARY, DESCRIPTION, BUGTRACKER and SECTION
* Update HOMEPAGE to agree with PyPi

https://github.com/python/typing_extensions/blob/main/CHANGELOG.md#release-440-october-6-2022

Release 4.4.0 (October 6, 2022)

* Add typing_extensions.Any a backport of python 3.11's Any class
  which is subclassable at runtime. (backport from python/cpython#31841,
  by Shantanu and Jelle Zijlstra). Patch by James Hilton-Balfe
  (@Gobot1234).
* Add initial support for TypeVarLike default parameter, PEP 696.
  Patch by Marc Mueller (@cdce8p).
* Runtime support for PEP 698, adding typing_extensions.override.
  Patch by Jelle Zijlstra.
* Add the infer_variance parameter to TypeVar, as specified in PEP
  695. Patch by Jelle Zijlstra.

License-Update: update copyright years; align with CPython LICENSE

See python/typing_extensions#63

(From OE-Core rev: 6dc6c11b638c1d45f4dc9c7813f93a09229c33b3)

Signed-off-by: Tim Orling <tim.orling@konsulko.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
kraj pushed a commit to YoeDistro/poky that referenced this pull request Nov 4, 2022
@moto-timo [@moto-timo] @alexandrebelloni [@alexandrebelloni]
python3-typing-extensions: upgrade 4.3.0 -> 4.4.0 …
0cda3e8 
* Add SUMMARY, DESCRIPTION, BUGTRACKER and SECTION
* Update HOMEPAGE to agree with PyPi

https://github.com/python/typing_extensions/blob/main/CHANGELOG.md#release-440-october-6-2022

Release 4.4.0 (October 6, 2022)

* Add typing_extensions.Any a backport of python 3.11's Any class
  which is subclassable at runtime. (backport from python/cpython#31841,
  by Shantanu and Jelle Zijlstra). Patch by James Hilton-Balfe
  (@Gobot1234).
* Add initial support for TypeVarLike default parameter, PEP 696.
  Patch by Marc Mueller (@cdce8p).
* Runtime support for PEP 698, adding typing_extensions.override.
  Patch by Jelle Zijlstra.
* Add the infer_variance parameter to TypeVar, as specified in PEP
  695. Patch by Jelle Zijlstra.

License-Update: update copyright years; align with CPython LICENSE

See python/typing_extensions#63

(From OE-Core rev: 0cb15457edaa6cee3ac152a18d8b6ba4204dd958)

Signed-off-by: Tim Orling <tim.orling@konsulko.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
kraj pushed a commit to YoeDistro/poky that referenced this pull request Nov 7, 2022
@moto-timo [@moto-timo] @alexandrebelloni [@alexandrebelloni]
python3-typing-extensions: upgrade 4.3.0 -> 4.4.0 …
948569c 
* Add SUMMARY, DESCRIPTION, BUGTRACKER and SECTION
* Update HOMEPAGE to agree with PyPi

https://github.com/python/typing_extensions/blob/main/CHANGELOG.md#release-440-october-6-2022

Release 4.4.0 (October 6, 2022)

* Add typing_extensions.Any a backport of python 3.11's Any class
  which is subclassable at runtime. (backport from python/cpython#31841,
  by Shantanu and Jelle Zijlstra). Patch by James Hilton-Balfe
  (@Gobot1234).
* Add initial support for TypeVarLike default parameter, PEP 696.
  Patch by Marc Mueller (@cdce8p).
* Runtime support for PEP 698, adding typing_extensions.override.
  Patch by Jelle Zijlstra.
* Add the infer_variance parameter to TypeVar, as specified in PEP
  695. Patch by Jelle Zijlstra.

License-Update: update copyright years; align with CPython LICENSE

See python/typing_extensions#63

(From OE-Core rev: 0cb15457edaa6cee3ac152a18d8b6ba4204dd958)

Signed-off-by: Tim Orling <tim.orling@konsulko.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
rpurdie pushed a commit to yoctoproject/poky that referenced this pull request Nov 7, 2022
@moto-timo [@moto-timo] @rpurdie [@rpurdie]
python3-typing-extensions: upgrade 4.3.0 -> 4.4.0 …
de15d93 
* Add SUMMARY, DESCRIPTION, BUGTRACKER and SECTION
* Update HOMEPAGE to agree with PyPi

https://github.com/python/typing_extensions/blob/main/CHANGELOG.md#release-440-october-6-2022

Release 4.4.0 (October 6, 2022)

* Add typing_extensions.Any a backport of python 3.11's Any class
  which is subclassable at runtime. (backport from python/cpython#31841,
  by Shantanu and Jelle Zijlstra). Patch by James Hilton-Balfe
  (@Gobot1234).
* Add initial support for TypeVarLike default parameter, PEP 696.
  Patch by Marc Mueller (@cdce8p).
* Runtime support for PEP 698, adding typing_extensions.override.
  Patch by Jelle Zijlstra.
* Add the infer_variance parameter to TypeVar, as specified in PEP
  695. Patch by Jelle Zijlstra.

License-Update: update copyright years; align with CPython LICENSE

See python/typing_extensions#63

(From OE-Core rev: 15ca091ae01ae298c013e8cf82ee6af382259ed8)

Signed-off-by: Tim Orling <tim.orling@konsulko.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
halstead pushed a commit to openembedded/openembedded-core that referenced this pull request Nov 7, 2022
@moto-timo [@moto-timo] @rpurdie [@rpurdie]
python3-typing-extensions: upgrade 4.3.0 -> 4.4.0 …
15ca091 
* Add SUMMARY, DESCRIPTION, BUGTRACKER and SECTION
* Update HOMEPAGE to agree with PyPi

https://github.com/python/typing_extensions/blob/main/CHANGELOG.md#release-440-october-6-2022

Release 4.4.0 (October 6, 2022)

* Add typing_extensions.Any a backport of python 3.11's Any class
  which is subclassable at runtime. (backport from python/cpython#31841,
  by Shantanu and Jelle Zijlstra). Patch by James Hilton-Balfe
  (@Gobot1234).
* Add initial support for TypeVarLike default parameter, PEP 696.
  Patch by Marc Mueller (@cdce8p).
* Runtime support for PEP 698, adding typing_extensions.override.
  Patch by Jelle Zijlstra.
* Add the infer_variance parameter to TypeVar, as specified in PEP
  695. Patch by Jelle Zijlstra.

License-Update: update copyright years; align with CPython LICENSE

See python/typing_extensions#63

Signed-off-by: Tim Orling <tim.orling@konsulko.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
@hauntsaninja [@hauntsaninja] hauntsaninja mentioned this pull request Aug 1, 2023
Closed
[Go]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Footer

© 2026 GitHub, Inc.
Web Proxy Viewer  |  New URL  |  Original Page