[ Web Proxy ]
URL:
Viewing: https://github-redirect.dependabot.com/python/cpython/pull/156181 [Back]  [Original]
gh-156180: Reject a negative `len2` in `zlib.{adler32,crc32}_combine()` by StanFromIreland Pull Request #156181 python/cpython GitHub
Skip to content

Navigation Menu

Sign in
Search/
Sign in
Sign up
  1. python
  2. cpython

Repository navigation

More items

gh-156180: Reject a negative len2 in zlib.{adler32,crc32}_combine() - #156181

Merged
StanFromIreland merged 3 commits into
python:mainfrom
StanFromIreland:zlib-negative
Aug 22, 2026
ConversationCommits(3)ChecksFiles changed
Merged

gh-156180: Reject a negative len2 in zlib.{adler32,crc32}_combine()#156181
StanFromIreland merged 3 commits into
python:mainfrom
StanFromIreland:zlib-negative

Conversation

@StanFromIreland [@StanFromIreland]

@StanFromIreland [@StanFromIreland] StanFromIreland commented Aug 21, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member
[Go]
@bedevere-app [@bedevere-app] bedevere-app Bot mentioned this pull request Aug 21, 2026
Closed
picnixz [picnixz]
picnixz reviewed Aug 22, 2026
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2026-08-21-14-30-00.gh-issue-156180.Qz3Lv8.rst Outdated Show resolved Hide resolved
picnixz [picnixz]
picnixz reviewed Aug 22, 2026
View reviewed changes
Comment thread Modules/zlibmodule.c Show resolved Hide resolved
picnixz [picnixz]
picnixz reviewed Aug 22, 2026
View reviewed changes
Comment thread Lib/test/test_zlib.py Show resolved Hide resolved
serhiy-storchaka [serhiy-storchaka]
serhiy-storchaka approved these changes Aug 22, 2026
View reviewed changes

@serhiy-storchaka [@serhiy-storchaka] serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Hide comment]

LGTM.

[Go]
Comment thread Lib/test/test_zlib.py Show resolved Hide resolved
@StanFromIreland [@StanFromIreland] @picnixz [@picnixz]
Bndikt's nits …
e9d781c 
Co-authored-by: Bndikt Tran <10796600+picnixz@users.noreply.github.com>
picnixz [picnixz]
picnixz approved these changes Aug 22, 2026
View reviewed changes
Comment thread Modules/zlibmodule.c Show resolved Hide resolved
Hide details View details
@StanFromIreland [@StanFromIreland]
StanFromIreland merged commit b062727 into python:main Aug 22, 2026
54 checks passed
@miss-islington-app [@miss-islington-app]

miss-islington-app Bot commented Aug 22, 2026

Copy link
Copy Markdown

Thanks @StanFromIreland for the PR .. I'm working now to backport this PR to: 3.15.
[Go]
@bedevere-app [@bedevere-app]

bedevere-app Bot commented Aug 22, 2026

Copy link
Copy Markdown

GH-156239 is a backport of this pull request to the 3.15 branch.
[Go]
@bedevere-app [@bedevere-app] bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Aug 22, 2026
@StanFromIreland [@StanFromIreland]

StanFromIreland commented Aug 22, 2026

Copy link
Copy Markdown
Member Author

Thanks for the reviews!
[Go]
StanFromIreland added a commit that referenced this pull request Oct 9, 2026
@miss-islington [@miss-islington] @StanFromIreland [@StanFromIreland] @picnixz [@picnixz]
[3.15] gh-156180: Reject a negative len2 in `zlib.{adler32,crc32}_c …
306290c 
ombine()` (GH-156181) (#156239)

(cherry picked from commit b062727)

Co-authored-by: Stan Ulbrych <stan@python.org>
Co-authored-by: Bndikt Tran <10796600+picnixz@users.noreply.github.com>
[Go]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Footer

© 2026 GitHub, Inc.
Web Proxy Viewer  |  New URL  |  Original Page